| Message ID | 20240324022504.1419451-1-marth64@proxyid.net |
|---|---|
| Headers | show |
| Series | RCWT Closed Captions demuxer (v9) | expand |
Ping if possible. The patches still apply. 3 of the 5 patches are documentation only and the demuxer itself is much smaller now. The muxer already made it in, so was hoping the demuxer could go too :fingers_crossed:
On date Tuesday 2024-03-26 10:29:18 -0500, Marth64 wrote: > Ping if possible. The patches still apply. 3 of the 5 patches are > documentation only and the demuxer itself is much smaller now. The muxer > already made it in, so was hoping the demuxer could go too :fingers_crossed: I sent a few comments but in general looks good to me, will wait a few days to see if there are more comments and will push otherwise.
On date Tuesday 2024-03-26 17:07:01 +0100, Stefano Sabatini wrote: > On date Tuesday 2024-03-26 10:29:18 -0500, Marth64 wrote: > > Ping if possible. The patches still apply. 3 of the 5 patches are > > documentation only and the demuxer itself is much smaller now. The muxer > > already made it in, so was hoping the demuxer could go too :fingers_crossed: > > I sent a few comments but in general looks good to me, will wait a few > days to see if there are more comments and will push otherwise. Marth64: I see an unaddressed comment by Andreas, I'll wait for the next update before merging.
Thanks for checking Stefano, I have been behind a bit. I will follow up with the fix once possible.
Stefano, v10 coming shortly. Thank you!
Since v7/8: * Simplified demuxer error handling logic * Fixes buggy change to ff_subtitles_queue_insert() * Documentation improvements Signed-off-by: Marth64 <marth64@proxyid.net>