mbox series

[FFmpeg-devel,v3,0/2] avfilter/vf_colorspace: Use colorspace negotiation API

Message ID 20240402130559.382049-1-nicolas.gaullier@cji.paris
Headers show
Series avfilter/vf_colorspace: Use colorspace negotiation API | expand

Message

Nicolas Gaullier April 2, 2024, 1:05 p.m. UTC 
v3:
- Fixes case where colorspace is the first filter (no inlink)
- Illustrates with proper examples in commit msg (use yuvtestsrc instead of testsrc)

Please note that it is a regression compared to the previous release:
both examples (see commit msg) behave the same way as 6.1 after this patch.


Nicolas Gaullier (2):
  avfilter/vf_setparams: Add timeline support
  avfilter/vf_colorspace: Use colorspace negotiation API

 libavfilter/vf_colorspace.c | 63 +++++++++++++++++++++----------------
 libavfilter/vf_setparams.c  |  2 +-
 2 files changed, 37 insertions(+), 28 deletions(-)

Comments

Nicolas Gaullier April 4, 2024, 8:15 a.m. UTC | #1 
>Envoyé : mardi 2 avril 2024 15:06
>
>v3:
>- Fixes case where colorspace is the first filter (no inlink)
>- Illustrates with proper examples in commit msg (use yuvtestsrc instead of testsrc)
>
>Please note that it is a regression compared to the previous release:
>both examples (see commit msg) behave the same way as 6.1 after this patch.
>
>Nicolas Gaullier (2):
>  avfilter/vf_setparams: Add timeline support
>  avfilter/vf_colorspace: Use colorspace negotiation API

Any chance to get this regression fixed for 7.0 one way or another?
For remembering:
./ffprobe -f lavfi -i yuvtestsrc,setparams=color_primaries=bt470bg:color_trc=smpte170m:colorspace=bt470bg,colorspace=bt709:range=tv,scale,showinfo 2>&1|grep color_space
Current code:
color_range:unknown color_space:bt470bg ...
Release 6.1: (expected values) [or current code with my proposed patch]
color_range:tv color_space:bt709 ...

Thanks
Nicolas