mbox series

[FFmpeg-devel,0/1] avfilter/framesync: fix forward EOF pts

Message ID 20240528091117.139346-1-nicolas.gaullier@cji.paris
Headers show
Series avfilter/framesync: fix forward EOF pts | expand

Message

Nicolas Gaullier May 28, 2024, 9:11 a.m. UTC 
This a new ping but I post the patch again to get fate cleanly completed
on patchwork.
BTW, the initial design of framesync/EOF was in n3.4-dev-1799-g4e0e9ce2dc,
so one can say that time has past...

Thank you in advance for the review.
Nicolas

Nicolas Gaullier (1):
  avfilter/framesync: fix forward EOF pts

 libavfilter/framesync.c | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

Comments

Nicolas Gaullier June 3, 2024, 10 a.m. UTC | #1 
>Envoyé : mardi 28 mai 2024 11:11
>
>This a new ping but I post the patch again to get fate cleanly completed on patchwork.
>BTW, the initial design of framesync/EOF was in n3.4-dev-1799-g4e0e9ce2dc, so one can say that time has past...
>
>Thank you in advance for the review.
>Nicolas

Another ping.
Patch still applies
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=11939

Thank you
Nicolas
Nicolas Gaullier June 14, 2024, 11:26 a.m. UTC | #2 
>Envoyé : lundi 3 juin 2024 12:00
>>Envoyé : mardi 28 mai 2024 11:11
>>
>>This a new ping but I post the patch again to get fate cleanly completed on patchwork.
>>BTW, the initial design of framesync/EOF was in n3.4-dev-1799-g4e0e9ce2dc, so one can say that time has past...
>>
>>Thank you in advance for the review.
>>Nicolas
>
>Another ping.
>Patch still applies
>https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=11939

Still applies to current master.
Anyone to review ?
To summarize, and for remembering, the initial commit was 4e0e9ce2dc, 7 years ago, and inserted this:
ff_outlink_set_status(fs->parent->outputs[0], AVERROR_EOF, AV_NOPTS_VALUE)
The target of this patch is to make it a:
ff_outlink_set_status(fs->parent->outputs[0], AVERROR_EOF, eof_pts)

My use case is that I frequently chain the scale filter with the fps filter,
and since the scale filter use framesync since e82a3997cdd6c0 (3rd of May this year),
this is becoming a full issue (yet I have not find any corresponding trac entry so far).

Thanks
Nicolas