[FFmpeg-devel,v3,00/17] Add avcodec_get_supported_config()

Message ID	20240830102402.18149-1-ffmpeg@haasn.xyz
Headers	show Delivered-To: ffmpegpatchwork2@gmail.com Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; From: Niklas Haas <ffmpeg@haasn.xyz> To: ffmpeg-devel@ffmpeg.org Date: Fri, 30 Aug 2024 12:15:23 +0200 Message-ID: <20240830102402.18149-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 00/17] Add avcodec_get_supported_config() Precedence: list Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Series	Add avcodec_get_supported_config() \| expand [FFmpeg-devel,v3,00/17] Add avcodec_get_supported_config() [FFmpeg-devel,v3,01/17] avcodec/internal: add FFCodec.color_ranges [FFmpeg-devel,v3,02/17] avcodec: add avcodec_get_supported_config() [FFmpeg-devel,v3,03/17] avcodec/encode: switch to avcodec_get_supported_config() [FFmpeg-devel,v3,04/17] avcodec/allcodecs: add backcompat for new config API [FFmpeg-devel,v3,05/17] avcodec/libx265: switch to get_supported_config() [FFmpeg-devel,v3,06/17] avcodec/libvpxenc: switch to get_supported_config() [FFmpeg-devel,v3,07/17] avcodec/libaomenc: switch to get_supported_config() [FFmpeg-devel,v3,08/17] avcodec/mjpegenc: switch to get_supported_config() [FFmpeg-devel,v3,09/17] avcodec/codec_internal: nuke init_static_data() [FFmpeg-devel,v3,10/17] fftools/opt_common: switch to avcodec_get_supported_config() [FFmpeg-devel,v3,11/17] fftools: drop unused/hacky macros [FFmpeg-devel,v3,12/17] fftools/ffmpeg_mux_init: switch to avcodec_get_supported_config() [FFmpeg-devel,v3,13/17] fftools/ffmpeg_filter: simplify choose_pix_fmts [FFmpeg-devel,v3,14/17] fftools/ffmpeg_mux_init: factor out binding filters to output streams [FFmpeg-devel,v3,15/17] fftools/ffmpeg_filter: switch to avcodec_get_supported_config() [FFmpeg-devel,v3,16/17] fftools/ffmpeg_filter: propagate codec yuv metadata to filters [FFmpeg-devel,v3,17/17] fftools/ffmpeg_filter: remove YUVJ hack

Message ID

20240830102402.18149-1-ffmpeg@haasn.xyz

Headers

Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org
 designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100;
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Date: Fri, 30 Aug 2024 12:15:23 +0200
Message-ID: <20240830102402.18149-1-ffmpeg@haasn.xyz>
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH v3 00/17] Add avcodec_get_supported_config()
Precedence: list
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>

Series

Add avcodec_get_supported_config() | expand

Message

Niklas Haas Aug. 30, 2024, 10:15 a.m. UTC

Changes since v2:

- Rebased onto master
- Add length field, to be (optionally) populated by the callee.
- Rewrite fftools code to take advantage of this new length field

This should address the remaining feedback from Andreas.

One thing I did notice though is that the `const void **out_configs` signature
makes it a bit awkward for the caller to pass an allocated array controlled
by the caller. But on the other hand, changing this to a `void *` is also
pretty nasty an in particular makes it too easy to accidentally attempt
mutating `const static` data.