mbox series

[FFmpeg-devel,0/2] documentation changes

Message ID 20241001132409.71360-1-vipyne@gmail.com
Headers show
Series documentation changes | expand

Message

vipyne Oct. 1, 2024, 1:24 p.m. UTC 
The configure change suggests installing nasm/yasm in addition to suggesting the --disable-x86asm flag.
I also made a word change to better describe --disable-x86asm's affect on the build.
The doc/mailing-list-faq change removes the line that says one can simply email ffmpeg-user-request@ffmpeg.org
with the subject "subscribe".  I tried this and did not receive a confirmation email. If it no longer works,
we should remove it.
These should perhaps be two separate patches, but neither affect code, so I figure they can go together.


vipyne (2):
  configure: suggest installing nasm/yasm before using --disable-x86asm
  doc/mailing-list-faq: remove incorrect subscribe info

 configure                 | 2 +-
 doc/mailing-list-faq.texi | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

Comments

Lynne Oct. 3, 2024, 2:04 a.m. UTC | #1 
On 01/10/2024 15:24, vipyne wrote:
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index c8fb49a7a4..d178ef59dc 100755
> --- a/configure
> +++ b/configure
> @@ -6460,7 +6460,7 @@ EOF
>           for program in $x86asmexe nasm yasm; do
>               probe_x86asm $program && break
>           done
> -        disabled x86asm && die "nasm/yasm not found or too old. Use --disable-x86asm for a crippled build."
> +        disabled x86asm && die "nasm/yasm not found or too old. Please install/update nasm or yasm or use --disable-x86asm for a slower build."
>           X86ASMFLAGS="-f $objformat"
>           test -n "$extern_prefix"  && append X86ASMFLAGS "-DPREFIX"
>           case "$objformat" in

Could you remove the yasm mention? Its been holding us back and we've 
discussed dropping support for it enough in recent time to go ahead and 
do it any day now.
Otherwise LGTM.