Message ID | 98a4dbbde2c047b1bff825e771d5bf72@EX13D07UWB004.ant.amazon.com |
---|---|
Headers | show |
Series | checkasm: added additional dstW tests for hscale | expand |
On Thu, 26 May 2022, Swinney, Jonathan wrote: > I have fixed the test to work correctly on x86 and addressed the other small issues. Thanks for reviewing! > Thanks - this iteration seems fine to me! (I can touch up minor details like changing "add #-32" into "sub #32" before pushing.) I'll push these two patches in a day or two unless anything else comes up. // Martin
Thanks! If I don't see it merged in a few days, I will submit it again with the final touch up. -- Jonathan Swinney On 5/26/22, 4:21 PM, "Martin Storsjö" <martin@martin.st> wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Thu, 26 May 2022, Swinney, Jonathan wrote: > I have fixed the test to work correctly on x86 and addressed the other small issues. Thanks for reviewing! > Thanks - this iteration seems fine to me! (I can touch up minor details like changing "add #-32" into "sub #32" before pushing.) I'll push these two patches in a day or two unless anything else comes up. // Martin
On Fri, 27 May 2022, Swinney, Jonathan wrote: > Thanks! If I don't see it merged in a few days, I will submit it again > with the final touch up. Pushed now, thanks! // Martin