| Message ID | pull.26.v4.ffstaging.FFmpeg.1652790597.ffmpegagent@gmail.com |
|---|---|
| Headers | show |
| Series | use av_fopen_utf8() instead of plain fopen() | expand |
On 17/05/2022 14:29, ffmpegagent wrote: > Unify file access operations by replacing usages of direct calls to posix > fopen() > > v2: Remove changes to fftools for now > v3: Add some additional replacements > v4: Fix and improve commit messages > > softworkz (2): > avfilter: use av_fopen_utf8() instead of plain fopen() > avcodec/dvdsubdec: use av_fopen_utf8() instead of plain fopen() > > libavcodec/dvdsubdec.c | 2 +- > libavfilter/af_firequalizer.c | 2 +- > libavfilter/vf_deshake.c | 2 +- > libavfilter/vf_psnr.c | 2 +- > libavfilter/vf_signature.c | 4 ++-- > libavfilter/vf_ssim.c | 2 +- > libavfilter/vf_vidstabdetect.c | 2 +- > libavfilter/vf_vidstabtransform.c | 2 +- > libavfilter/vf_vmafmotion.c | 2 +- > 9 files changed, 10 insertions(+), 10 deletions(-) > > [...] Commit messages look fine to me now. I will leave the decision to others about the order of changes -- whether this patch-set comes first, or the fix for the CRT linking issue (possibly replacing this public function with a private copy). Regards, Tobias
> -----Original Message----- > From: Tobias Rapp <t.rapp@noa-archive.com> > Sent: Wednesday, May 18, 2022 9:01 AM > To: ffmpegagent <ffmpegagent@gmail.com>; ffmpeg-devel@ffmpeg.org > Cc: Martin Storsjö <martin@martin.st>; Soft Works > <softworkz@hotmail.com> > Subject: Re: [PATCH v4 0/2] use av_fopen_utf8() instead of plain > fopen() > > On 17/05/2022 14:29, ffmpegagent wrote: > > Unify file access operations by replacing usages of direct calls to > posix > > fopen() > > > > v2: Remove changes to fftools for now > > v3: Add some additional replacements > > v4: Fix and improve commit messages > > > > softworkz (2): > > avfilter: use av_fopen_utf8() instead of plain fopen() > > avcodec/dvdsubdec: use av_fopen_utf8() instead of plain fopen() > > > > libavcodec/dvdsubdec.c | 2 +- > > libavfilter/af_firequalizer.c | 2 +- > > libavfilter/vf_deshake.c | 2 +- > > libavfilter/vf_psnr.c | 2 +- > > libavfilter/vf_signature.c | 4 ++-- > > libavfilter/vf_ssim.c | 2 +- > > libavfilter/vf_vidstabdetect.c | 2 +- > > libavfilter/vf_vidstabtransform.c | 2 +- > > libavfilter/vf_vmafmotion.c | 2 +- > > 9 files changed, 10 insertions(+), 10 deletions(-) > > > > [...] > > Commit messages look fine to me now. I will leave the decision to > others > about the order of changes -- whether this patch-set comes first, or > the > fix for the CRT linking issue (possibly replacing this public function > with a private copy). To eliminate the question, I'm including that change in the v5 of this patchset. Thanks, softworkz
Unify file access operations by replacing usages of direct calls to posix fopen() v2: Remove changes to fftools for now v3: Add some additional replacements v4: Fix and improve commit messages softworkz (2): avfilter: use av_fopen_utf8() instead of plain fopen() avcodec/dvdsubdec: use av_fopen_utf8() instead of plain fopen() libavcodec/dvdsubdec.c | 2 +- libavfilter/af_firequalizer.c | 2 +- libavfilter/vf_deshake.c | 2 +- libavfilter/vf_psnr.c | 2 +- libavfilter/vf_signature.c | 4 ++-- libavfilter/vf_ssim.c | 2 +- libavfilter/vf_vidstabdetect.c | 2 +- libavfilter/vf_vidstabtransform.c | 2 +- libavfilter/vf_vmafmotion.c | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) base-commit: e3580f60775c897c3b13b178c57ab191ecc4a031 Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-26%2Fsoftworkz%2Fsubmit_replace_fopen-v4 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-26/softworkz/submit_replace_fopen-v4 Pull-Request: https://github.com/ffstaging/FFmpeg/pull/26 Range-diff vs v3: 1: d81855ba42 ! 1: 7c455d7fa0 avfilter: use av_fopen_utf8() instead of plain fopen() @@ Metadata ## Commit message ## avfilter: use av_fopen_utf8() instead of plain fopen() + Unify file access operations by replacing usages of direct calls + to posix fopen() to prepare for long filename support on Windows. + Signed-off-by: softworkz <softworkz@hotmail.com> ## libavfilter/af_firequalizer.c ## 2: 1be02d9e04 ! 2: 68192b1a1e avfilter/dvdsubdec: use av_fopen_utf8() instead of plain fopen() @@ Metadata Author: softworkz <softworkz@hotmail.com> ## Commit message ## - avfilter/dvdsubdec: use av_fopen_utf8() instead of plain fopen() + avcodec/dvdsubdec: use av_fopen_utf8() instead of plain fopen() + + Unify file access operations by replacing usages of direct calls + to posix fopen() to prepare for long filename support on Windows. Signed-off-by: softworkz <softworkz@hotmail.com>