| Message ID | 0101018b967a36dd-054beb70-1080-4c9d-ac9f-d1193adf13a1-000000@us-west-2.amazonses.com |
|---|---|
| State | New |
| Headers | show |
| Series | tools/general_assembly.pl - print names with emails | expand |
Cosmin Stejerean via ffmpeg-devel (12023-11-03): > Update GA script to print names in addition to emails since emails > should not be shared in all contexts, this makes it easier to publish > the current GA membership. > > Signed-off-by: Cosmin Stejerean <cosmin@cosmin.at> > --- > tools/general_assembly.pl | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/general_assembly.pl b/tools/general_assembly.pl > index 898a6262ef..aa467ba34a 100644 > --- a/tools/general_assembly.pl > +++ b/tools/general_assembly.pl > @@ -7,6 +7,8 @@ use POSIX qw(strftime); > use Encode qw(decode); > use Data::Dumper; > > +binmode(STDOUT, ":utf8"); > + > sub trim { my $s = shift; $s =~ s/^\s+|\s+$//g; return $s }; > > my @shortlog = split /\n/, decode('UTF-8', `git log --pretty=format:"%aN <%aE>" --since="last 36 months" | sort | uniq -c | sort -r`, Encode::FB_CROAK); > @@ -35,6 +37,7 @@ foreach my $line (@shortlog) { > } > > printf("# %s %s", strftime("%Y-%m-%d", localtime), decode('UTF-8', `git rev-parse HEAD`, Encode::FB_CROAK)); > -foreach my $email (sort values %assembly) { > - printf("%s\n", $email); > +foreach my $name (sort keys %assembly) { This is also changing the sort order. It might be acceptable but it might also not be. > + my $email = $assembly{$name}; > + printf("%s <%s>\n", $name, $email); > } Regards,
> On Nov 3, 2023, at 11:40 AM, Nicolas George <george@nsup.org> wrote: > > This is also changing the sort order. It might be acceptable but it > might also not be. It is and I probably should have called that out in the description. If the goal is to publish mostly names and not emails in various places like this list then it seems sorting by name would be more natural. But I'm happy to to update the patch with whatever sort order we want to use. - Cosmin
Hi, sorry can't comment on the ML atm as people will wonder why I respond to this but not to other "more important" mails... Set aside that I think its complete nonsense not to share the list of mail addresses directly for any legal consideration - all these mail addresses were put into a public repo and used on a public ML and there is no reason not to reshare public info. However if people (next to JB who I don't believe is actually having any legal considerations...) don't like it... The script should output two files then, so that no manual editing is required. The voting system expects a file with mail addresses one per line and the ML then shall be given the very same list but with only the names. Therefore I think the script should just output two files, ga_names.txt and ga_mails.txt. Thanks for the patch! -Thilo Am 03.11.23 um 20:18 schrieb Cosmin Stejerean via ffmpeg-devel: > > >> On Nov 3, 2023, at 11:40 AM, Nicolas George <george@nsup.org> wrote: >> >> This is also changing the sort order. It might be acceptable but it >> might also not be. > > It is and I probably should have called that out in the description. If the goal is to publish mostly names and not emails in various places like this list then it seems sorting by name would be more natural. But I'm happy to to update the patch with whatever sort order we want to use. > > - Cosmin > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >
Am 05.11.23 um 14:41 schrieb Thilo Borgmann via ffmpeg-devel: > Hi, > > sorry can't comment on the ML atm as people will wonder why I respond to this > but not to other "more important" mails... Having sent this private mail to the ML anyways just proves how much I should not post to the ML in my current state :-/ -Thilo
> On Nov 5, 2023, at 5:41 AM, Thilo Borgmann via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: > > The script should output two files then, so that no manual editing is required. > The voting system expects a file with mail addresses one per line and the ML then shall be given the very same list but with only the names. The editing in this case is fairly straight forward to extract the emails between the <>, but if we need a convenient "emails only" output option for the voting system I could also add some switches to the script to print only names, only emails or name and email for example. Outputting to a file (or more than one file) rather than to stdout is certainly an option as well but feels like a bigger change compared to some flags to control formatting. - Cosmin
On Mon, 6 Nov 2023, at 03:06, Cosmin Stejerean via ffmpeg-devel wrote: >> On Nov 5, 2023, at 5:41 AM, Thilo Borgmann via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: >> The script should output two files then, so that no manual editing is required. >> The voting system expects a file with mail addresses one per line and the ML then shall be given the very same list but with only the names. > > The editing in this case is fairly straight forward to extract the > emails between the <>, but if we need a convenient "emails only" output > option for the voting system I could also add some switches to the > script to print only names, only emails or name and email for example. That would be helpful, tbh.
diff --git a/tools/general_assembly.pl b/tools/general_assembly.pl index 898a6262ef..aa467ba34a 100644 --- a/tools/general_assembly.pl +++ b/tools/general_assembly.pl @@ -7,6 +7,8 @@ use POSIX qw(strftime); use Encode qw(decode); use Data::Dumper; +binmode(STDOUT, ":utf8"); + sub trim { my $s = shift; $s =~ s/^\s+|\s+$//g; return $s }; my @shortlog = split /\n/, decode('UTF-8', `git log --pretty=format:"%aN <%aE>" --since="last 36 months" | sort | uniq -c | sort -r`, Encode::FB_CROAK); @@ -35,6 +37,7 @@ foreach my $line (@shortlog) { } printf("# %s %s", strftime("%Y-%m-%d", localtime), decode('UTF-8', `git rev-parse HEAD`, Encode::FB_CROAK)); -foreach my $email (sort values %assembly) { - printf("%s\n", $email); +foreach my $name (sort keys %assembly) { + my $email = $assembly{$name}; + printf("%s <%s>\n", $name, $email); }
Update GA script to print names in addition to emails since emails should not be shared in all contexts, this makes it easier to publish the current GA membership. Signed-off-by: Cosmin Stejerean <cosmin@cosmin.at> --- tools/general_assembly.pl | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)