| Message ID | 1473551073-20202-1-git-send-email-josh@itanimul.li |
|---|---|
| State | Superseded |
| Headers | show |
Le sextidi 26 fructidor, an CCXXIV, Josh de Kock a écrit :
> This device depends on SDL which is deprecated.
Are we in the business of deprecating things that do not have a replacement,
now?
Before deprecating the best video output device, making some effort to port
it to something more modern would be required.
Regards,
On 11/09/2016 08:36, Nicolas George wrote: > Le sextidi 26 fructidor, an CCXXIV, Josh de Kock a écrit : >> This device depends on SDL which is deprecated. > > Are we in the business of deprecating things that do not have a replacement, > now? > > Before deprecating the best video output device, making some effort to port > it to something more modern would be required. > > Regards, > For achieving the same result as the SDL/opengl outdevs you can do something like: ffmpeg -i t.mov -c:v ffv1 -c:a aac -f fifo -fifo_format mov -map 0:v fifo.mov & mpv fifo.mov Either way, an outdev isn't really the right place for a preview; what if you want to check how video/audio looks/sounds half way down a filtergraph? An avfilter would make much more sense for this.
Le sextidi 26 fructidor, an CCXXIV, Josh de Kock a écrit : > For achieving the same result as the SDL/opengl outdevs you can do something > like: > > ffmpeg -i t.mov -c:v ffv1 -c:a aac -f fifo -fifo_format mov -map 0:v > fifo.mov & mpv fifo.mov This is nowhere near the same functionality. > Either way, an outdev isn't really the right place for a preview; what if > you want to check how video/audio looks/sounds half way down a filtergraph? > An avfilter would make much more sense for this. Show me the code. But deprecating features without replacement is not ok. Regards,
diff --git a/Changelog b/Changelog index f609a86..6c9f766 100644 --- a/Changelog +++ b/Changelog @@ -27,7 +27,7 @@ version <next>: - weave filter - gblur filter - avgblur filter -- deprecated sdl outdev +- deprecated sdl and opengl outdev version 3.1: diff --git a/doc/outdevs.texi b/doc/outdevs.texi index cfcc176..34afa6f 100644 --- a/doc/outdevs.texi +++ b/doc/outdevs.texi @@ -214,6 +214,8 @@ See also @url{http://linux-fbdev.sourceforge.net/}, and fbset(1). @section opengl OpenGL output device. +This device is deprecated and will be removed in a future release. + To enable this output device you need to configure FFmpeg with @code{--enable-opengl}. This output device allows one to render to OpenGL context. diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c index 1dbbb80..d611830 100644 --- a/libavdevice/opengl_enc.c +++ b/libavdevice/opengl_enc.c @@ -1064,6 +1064,8 @@ static av_cold int opengl_write_header(AVFormatContext *h) AVStream *st; int ret; + av_log(h, AV_LOG_WARNING, "The opengl output device is deprecated.\n"); + if (h->nb_streams != 1 || h->streams[0]->codecpar->codec_type != AVMEDIA_TYPE_VIDEO || h->streams[0]->codecpar->codec_id != AV_CODEC_ID_RAWVIDEO) {
This device depends on SDL which is deprecated. Signed-off-by: Josh de Kock <josh@itanimul.li> --- Changelog | 2 +- doc/outdevs.texi | 2 ++ libavdevice/opengl_enc.c | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-)