diff mbox

[FFmpeg-devel,2/2] fate/fits: add missing png & gif dependencies

Message ID 1505507428-14308-2-git-send-email-paraschadha18@gmail.com
State Superseded
Headers show

Commit Message

Paras Sept. 15, 2017, 8:30 p.m. UTC
Signed-off-by: Paras Chadha <paraschadha18@gmail.com>
---
 tests/fate/fits.mak | 2 ++
 1 file changed, 2 insertions(+)

Comments

James Almer Sept. 15, 2017, 9:33 p.m. UTC | #1
On 9/15/2017 5:30 PM, Paras Chadha wrote:
> Signed-off-by: Paras Chadha <paraschadha18@gmail.com>
> ---
>  tests/fate/fits.mak | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/fate/fits.mak b/tests/fate/fits.mak
> index bc1b771..704f655 100644
> --- a/tests/fate/fits.mak
> +++ b/tests/fate/fits.mak
> @@ -1,3 +1,4 @@
> +tests/data/fits-multi.fits: $(TARGET_SAMPLES)/gif/m4nb.gif
>  tests/data/fits-multi.fits: TAG = GEN
>  tests/data/fits-multi.fits: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
>  	$(M)$(TARGET_EXEC) $(TARGET_PATH)/$< \
> @@ -10,6 +11,7 @@ map.tests/data/lena-gbrp.fits    := rgb24
>  map.tests/data/lena-gbrp16.fits  := rgb48
>  map.tests/data/lena-gbrap16.fits := rgba64
>  
> +tests/data/lena%.fits: $(TARGET_SAMPLES)/png1/lena-$(map.$(@)).png
>  tests/data/lena%.fits: TAG = GEN
>  tests/data/lena%.fits: NAME = $(map.$(@))
>  tests/data/lena%.fits: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
> 

This has no real effect. The dependency for any fate suite sample is
achieved by making a given test be part of FATE_SAMPLES_FFMPEG, which
all the fits ones already are.

What you need to do is what Michael mentioned. Making the tests using
the lena-$pixfmt.fits files depend on the png decoder/demuxer and the
one using fits-multi.fits depend on gif decoder/demuxer.
diff mbox

Patch

diff --git a/tests/fate/fits.mak b/tests/fate/fits.mak
index bc1b771..704f655 100644
--- a/tests/fate/fits.mak
+++ b/tests/fate/fits.mak
@@ -1,3 +1,4 @@ 
+tests/data/fits-multi.fits: $(TARGET_SAMPLES)/gif/m4nb.gif
 tests/data/fits-multi.fits: TAG = GEN
 tests/data/fits-multi.fits: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
 	$(M)$(TARGET_EXEC) $(TARGET_PATH)/$< \
@@ -10,6 +11,7 @@  map.tests/data/lena-gbrp.fits    := rgb24
 map.tests/data/lena-gbrp16.fits  := rgb48
 map.tests/data/lena-gbrap16.fits := rgba64
 
+tests/data/lena%.fits: $(TARGET_SAMPLES)/png1/lena-$(map.$(@)).png
 tests/data/lena%.fits: TAG = GEN
 tests/data/lena%.fits: NAME = $(map.$(@))
 tests/data/lena%.fits: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data