diff mbox

[FFmpeg-devel] avcodec/nvenc: set correct error code

Message ID 1511747570-23415-1-git-send-email-bianpan2016@163.com
State Accepted
Commit eb69e7bed80a1c8afee9acf9f8daff6be5e9ea62
Headers show

Commit Message

Pan Bian Nov. 27, 2017, 1:52 a.m. UTC 
In function process_output_surface(), the return value is 0 on the path
that av_mallocz() returns a NULL pointer. 0 indicates success, which
deviates from the fact. Return "AVERROR(ENOMEM)" instead of "0".

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 libavcodec/nvenc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Timo Rothenpieler Nov. 27, 2017, 9:54 a.m. UTC | #1 
lgtm
diff mbox

Patch

diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
index 79f7dce..1506062 100644
--- a/libavcodec/nvenc.c
+++ b/libavcodec/nvenc.c
@@ -1763,8 +1763,10 @@  static int process_output_surface(AVCodecContext *avctx, AVPacket *pkt, NvencSur
     }
     slice_offsets = av_mallocz(slice_mode_data * sizeof(*slice_offsets));
 
-    if (!slice_offsets)
+    if (!slice_offsets) {
+        res = AVERROR(ENOMEM);
         goto error;
+    }
 
     lock_params.version = NV_ENC_LOCK_BITSTREAM_VER;