diff mbox

[FFmpeg-devel,2/5] CodeAi generated fix for CWE 457 Uninitialized Variable

Message ID 1520376143-5925-3-git-send-email-benjamin.bales@assrc.us
State Superseded
Headers show

Commit Message

C0deAi March 6, 2018, 10:42 p.m. UTC 
Prevent uninitialized value 'pb[1]' being passed as an
argument on line 143.

Signed-off-by: C0deAi <benjamin.bales@assrc.us>
---
 libavformat/img2enc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nicolas George March 7, 2018, 2:42 p.m. UTC | #1 
C0deAi (2018-03-06):
> Prevent uninitialized value 'pb[1]' being passed as an
> argument on line 143.
> 
> Signed-off-by: C0deAi <benjamin.bales@assrc.us>
> ---
>  libavformat/img2enc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Nack. Passing NULL to avio_write() is just as wrong as passing
uninitialized. And it is not reachable anyway.

Regards,
diff mbox

Patch

diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
index a09cc8e..6cfbaa2 100644
--- a/libavformat/img2enc.c
+++ b/libavformat/img2enc.c
@@ -81,7 +81,7 @@  static int write_header(AVFormatContext *s)
 static int write_packet(AVFormatContext *s, AVPacket *pkt)
 {
     VideoMuxData *img = s->priv_data;
-    AVIOContext *pb[4];
+    AVIOContext *pb[4] = {0};
     char filename[1024];
     AVCodecParameters *par = s->streams[pkt->stream_index]->codecpar;
     const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(par->format);