diff mbox

[FFmpeg-devel,2/4] lavfi/tonemap: make use of AVFILTER_DEFINE_CLASS

Message ID 1551842307-3607-2-git-send-email-mypopydev@gmail.com
State Accepted
Commit 96451477b9115fb426016a152b3d40d2000c8549
Headers show

Commit Message

Jun Zhao March 6, 2019, 3:18 a.m. UTC 
From: Jun Zhao <barryjzhao@tencent.com>

use AVFILTER_DEFINE_CLASS for defining the filter classes

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavfilter/vf_tonemap.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

Comments

Michael Niedermayer March 7, 2019, 8:37 p.m. UTC | #1 
On Wed, Mar 06, 2019 at 11:18:25AM +0800, Jun Zhao wrote:
> From: Jun Zhao <barryjzhao@tencent.com>
> 
> use AVFILTER_DEFINE_CLASS for defining the filter classes
> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavfilter/vf_tonemap.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)

this and similar changes should be ok assuming they change
no value of the struct

thx

[...]
mypopy@gmail.com March 8, 2019, 1:36 a.m. UTC | #2 
On Fri, Mar 8, 2019 at 4:38 AM Michael Niedermayer
<michael@niedermayer.cc> wrote:
>
> On Wed, Mar 06, 2019 at 11:18:25AM +0800, Jun Zhao wrote:
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > use AVFILTER_DEFINE_CLASS for defining the filter classes
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >  libavfilter/vf_tonemap.c |    8 +-------
> >  1 files changed, 1 insertions(+), 7 deletions(-)
>
> this and similar changes should be ok assuming they change
> no value of the struct
>
> thx
>
Will apply, thx
diff mbox

Patch

diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c
index 98a2c4b..efd4af5 100644
--- a/libavfilter/vf_tonemap.c
+++ b/libavfilter/vf_tonemap.c
@@ -287,13 +287,7 @@  static const AVOption tonemap_options[] = {
     { NULL }
 };
 
-static const AVClass tonemap_class = {
-    .class_name       = "tonemap",
-    .item_name        = av_default_item_name,
-    .option           = tonemap_options,
-    .version          = LIBAVUTIL_VERSION_INT,
-    .category         = AV_CLASS_CATEGORY_FILTER,
-};
+AVFILTER_DEFINE_CLASS(tonemap);
 
 static const AVFilterPad tonemap_inputs[] = {
     {