diff mbox

[FFmpeg-devel,v3] avfilter/avf_showwaves: Add draw mode also to showwavespic filter

Message ID 1556259431-9793-1-git-send-email-vobruba.martin@gmail.com
State Accepted
Commit 093a504414ef7781123f0db49326b0059e32a818
Headers show

Commit Message

Martin Vobruba April 26, 2019, 6:17 a.m. UTC 
See commit a8c2d375ca68b7f001564ced14d8ac0757f53a29
---
 doc/filters.texi            | 14 ++++++++++++++
 libavfilter/avf_showwaves.c |  3 +++
 2 files changed, 17 insertions(+)

Comments

Martin Vobruba April 30, 2019, 2:55 p.m. UTC | #1 
> See commit a8c2d375ca68b7f001564ced14d8ac0757f53a29
> ---
>  doc/filters.texi            | 14 ++++++++++++++
>  libavfilter/avf_showwaves.c |  3 +++
>  2 files changed, 17 insertions(+)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index e9cbccc..2aabe8a 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -22645,6 +22645,20 @@ Cubic root.
>  @end table
> Default is linear.
> +
> +@item draw
> +Set the draw mode.
> +
> +Available values are:
> +@table @samp
> +@item scale
> +Scale pixel values for each drawn sample.
> +
> +@item full
> +Draw every sample directly.
> +@end table
> +
> +Default value is @code{scale}.
>  @end table
> @subsection Examples
> diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c
> index 0e683cf..a0d2b25 100644
> --- a/libavfilter/avf_showwaves.c
> +++ b/libavfilter/avf_showwaves.c
> @@ -765,6 +765,9 @@ static const AVOption showwavespic_options[] = {
>          { "log", "logarithmic",    0, AV_OPT_TYPE_CONST,  
> {.i64=SCALE_LOG}, .flags=FLAGS, .unit="scale"},
>          { "sqrt", "square root",   0, AV_OPT_TYPE_CONST,  
> {.i64=SCALE_SQRT}, .flags=FLAGS, .unit="scale"},
>          { "cbrt", "cubic root",    0, AV_OPT_TYPE_CONST,  
> {.i64=SCALE_CBRT}, .flags=FLAGS, .unit="scale"},
> +    { "draw", "set draw mode", OFFSET(draw_mode), AV_OPT_TYPE_INT,  
> {.i64 = DRAW_SCALE}, 0, DRAW_NB-1, FLAGS, .unit="draw" },
> +        { "scale", "scale pixel values for each drawn sample", 0,  
> AV_OPT_TYPE_CONST, {.i64=DRAW_SCALE}, .flags=FLAGS, .unit="draw"},
> +        { "full",  "draw every pixel for sample directly",     0,  
> AV_OPT_TYPE_CONST, {.i64=DRAW_FULL},  .flags=FLAGS, .unit="draw"},
>      { NULL }
>  };
>

Any feedback please?
Paul B Mahol April 30, 2019, 4:01 p.m. UTC | #2 
On 4/30/19, Martin Vobruba <vobruba.martin@gmail.com> wrote:
>> See commit a8c2d375ca68b7f001564ced14d8ac0757f53a29
>> ---
>>  doc/filters.texi            | 14 ++++++++++++++
>>  libavfilter/avf_showwaves.c |  3 +++
>>  2 files changed, 17 insertions(+)
>>
>> diff --git a/doc/filters.texi b/doc/filters.texi
>> index e9cbccc..2aabe8a 100644
>> --- a/doc/filters.texi
>> +++ b/doc/filters.texi
>> @@ -22645,6 +22645,20 @@ Cubic root.
>>  @end table
>> Default is linear.
>> +
>> +@item draw
>> +Set the draw mode.
>> +
>> +Available values are:
>> +@table @samp
>> +@item scale
>> +Scale pixel values for each drawn sample.
>> +
>> +@item full
>> +Draw every sample directly.
>> +@end table
>> +
>> +Default value is @code{scale}.
>>  @end table
>> @subsection Examples
>> diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c
>> index 0e683cf..a0d2b25 100644
>> --- a/libavfilter/avf_showwaves.c
>> +++ b/libavfilter/avf_showwaves.c
>> @@ -765,6 +765,9 @@ static const AVOption showwavespic_options[] = {
>>          { "log", "logarithmic",    0, AV_OPT_TYPE_CONST,
>> {.i64=SCALE_LOG}, .flags=FLAGS, .unit="scale"},
>>          { "sqrt", "square root",   0, AV_OPT_TYPE_CONST,
>> {.i64=SCALE_SQRT}, .flags=FLAGS, .unit="scale"},
>>          { "cbrt", "cubic root",    0, AV_OPT_TYPE_CONST,
>> {.i64=SCALE_CBRT}, .flags=FLAGS, .unit="scale"},
>> +    { "draw", "set draw mode", OFFSET(draw_mode), AV_OPT_TYPE_INT,
>> {.i64 = DRAW_SCALE}, 0, DRAW_NB-1, FLAGS, .unit="draw" },
>> +        { "scale", "scale pixel values for each drawn sample", 0,
>> AV_OPT_TYPE_CONST, {.i64=DRAW_SCALE}, .flags=FLAGS, .unit="draw"},
>> +        { "full",  "draw every pixel for sample directly",     0,
>> AV_OPT_TYPE_CONST, {.i64=DRAW_FULL},  .flags=FLAGS, .unit="draw"},
>>      { NULL }
>>  };
>>
>
> Any feedback please?

Was applied.
diff mbox

Patch

diff --git a/doc/filters.texi b/doc/filters.texi
index e9cbccc..2aabe8a 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -22645,6 +22645,20 @@  Cubic root.
 @end table
 
 Default is linear.
+
+@item draw
+Set the draw mode.
+
+Available values are:
+@table @samp
+@item scale
+Scale pixel values for each drawn sample.
+
+@item full
+Draw every sample directly.
+@end table
+
+Default value is @code{scale}.
 @end table
 
 @subsection Examples
diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c
index 0e683cf..a0d2b25 100644
--- a/libavfilter/avf_showwaves.c
+++ b/libavfilter/avf_showwaves.c
@@ -765,6 +765,9 @@  static const AVOption showwavespic_options[] = {
         { "log", "logarithmic",    0, AV_OPT_TYPE_CONST, {.i64=SCALE_LOG}, .flags=FLAGS, .unit="scale"},
         { "sqrt", "square root",   0, AV_OPT_TYPE_CONST, {.i64=SCALE_SQRT}, .flags=FLAGS, .unit="scale"},
         { "cbrt", "cubic root",    0, AV_OPT_TYPE_CONST, {.i64=SCALE_CBRT}, .flags=FLAGS, .unit="scale"},
+    { "draw", "set draw mode", OFFSET(draw_mode), AV_OPT_TYPE_INT, {.i64 = DRAW_SCALE}, 0, DRAW_NB-1, FLAGS, .unit="draw" },
+        { "scale", "scale pixel values for each drawn sample", 0, AV_OPT_TYPE_CONST, {.i64=DRAW_SCALE}, .flags=FLAGS, .unit="draw"},
+        { "full",  "draw every pixel for sample directly",     0, AV_OPT_TYPE_CONST, {.i64=DRAW_FULL},  .flags=FLAGS, .unit="draw"},
     { NULL }
 };