diff mbox

[FFmpeg-devel] add FF_DECODE_ERROR_DECODE_SLICES flag for AVFrame.decode_error_flags

Message ID 1561126555-23448-1-git-send-email-amir@livelyvideo.tv
State Accepted
Commit a30e44098ad4c57c1c78556ba85fe42f97fe2e8b
Headers show

Commit Message

Amir Pauker June 21, 2019, 2:15 p.m. UTC
FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with error(s) but the returned value from
avcodec_receive_frame is zero

Signed-off-by: Amir Pauker <amir@livelyvideo.tv>
---
 doc/APIchanges      | 3 +++
 libavutil/frame.h   | 1 +
 libavutil/version.h | 2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)

Comments

Michael Niedermayer June 22, 2019, 8:11 a.m. UTC | #1
On Fri, Jun 21, 2019 at 07:15:55AM -0700, Amir Pauker wrote:
> FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with error(s) but the returned value from
> avcodec_receive_frame is zero
> 
> Signed-off-by: Amir Pauker <amir@livelyvideo.tv>
> ---
>  doc/APIchanges      | 3 +++
>  libavutil/frame.h   | 1 +
>  libavutil/version.h | 2 +-
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 29a1936..b5fadc2 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -15,6 +15,9 @@ libavutil:     2017-10-21
>  
>  API changes, most recent first:
>  
> +2019-06-21 - XXXXXXXXXX - lavu 56.30.100 - frame.h
> +  Add FF_DECODE_ERROR_DECODE_SLICES
> +
>  2019-06-14 - XXXXXXXXXX - lavu 56.29.100 - frame.h
>    Add FF_DECODE_ERROR_CONCEALMENT_ACTIVE
>  
> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index 54e682e..732b077 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -564,6 +564,7 @@ typedef struct AVFrame {
>  #define FF_DECODE_ERROR_INVALID_BITSTREAM   1
>  #define FF_DECODE_ERROR_MISSING_REFERENCE   2
>  #define FF_DECODE_ERROR_CONCEALMENT_ACTIVE  4
> +#define FF_DECODE_ERROR_DECODE_SLICES       8

LGTM

thx


[...]
Michael Niedermayer June 22, 2019, 8:12 a.m. UTC | #2
On Fri, Jun 21, 2019 at 07:15:55AM -0700, Amir Pauker wrote:
> FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with error(s) but the returned value from
> avcodec_receive_frame is zero

The first line of the commit message needs a "avutil:" prefix or similar
also the first line should ideally be shorter and a summary of the change

[...]
Amir Pauker June 28, 2019, 9:20 a.m. UTC | #3
Sorry Michael I missed this one. I submitted an updated patch.

Thanks
Amir

On Sat, Jun 22, 2019 at 11:13 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Fri, Jun 21, 2019 at 07:15:55AM -0700, Amir Pauker wrote:
> > FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with
> error(s) but the returned value from
> > avcodec_receive_frame is zero
>
> The first line of the commit message needs a "avutil:" prefix or similar
> also the first line should ideally be shorter and a summary of the change
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The real ebay dictionary, page 2
> "100% positive feedback" - "All either got their money back or didnt
> complain"
> "Best seller ever, very honest" - "Seller refunded buyer after failed scam"
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/doc/APIchanges b/doc/APIchanges
index 29a1936..b5fadc2 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -15,6 +15,9 @@  libavutil:     2017-10-21
 
 API changes, most recent first:
 
+2019-06-21 - XXXXXXXXXX - lavu 56.30.100 - frame.h
+  Add FF_DECODE_ERROR_DECODE_SLICES
+
 2019-06-14 - XXXXXXXXXX - lavu 56.29.100 - frame.h
   Add FF_DECODE_ERROR_CONCEALMENT_ACTIVE
 
diff --git a/libavutil/frame.h b/libavutil/frame.h
index 54e682e..732b077 100644
--- a/libavutil/frame.h
+++ b/libavutil/frame.h
@@ -564,6 +564,7 @@  typedef struct AVFrame {
 #define FF_DECODE_ERROR_INVALID_BITSTREAM   1
 #define FF_DECODE_ERROR_MISSING_REFERENCE   2
 #define FF_DECODE_ERROR_CONCEALMENT_ACTIVE  4
+#define FF_DECODE_ERROR_DECODE_SLICES       8
 
     /**
      * number of audio channels, only used for audio.
diff --git a/libavutil/version.h b/libavutil/version.h
index dccbb38..e16b93e 100644
--- a/libavutil/version.h
+++ b/libavutil/version.h
@@ -79,7 +79,7 @@ 
  */
 
 #define LIBAVUTIL_VERSION_MAJOR  56
-#define LIBAVUTIL_VERSION_MINOR  29
+#define LIBAVUTIL_VERSION_MINOR  30
 #define LIBAVUTIL_VERSION_MICRO 100
 
 #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \