diff mbox series

[FFmpeg-devel] lavfi/vf_scale_qsv: fix the class_name in help for scale_qsv

Message ID 1579596614-25399-1-git-send-email-linjie.fu@intel.com
State Accepted
Headers show
Series [FFmpeg-devel] lavfi/vf_scale_qsv: fix the class_name in help for scale_qsv
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Fu, Linjie Jan. 21, 2020, 8:50 a.m. UTC
Class name is used in show_help_children(avfilter_get_class(),...)
to prompt the available filters.

$ ffmpeg -h full

Before:
qsvscale AVOptions:

After:
scale_qsv AVOptions:

Signed-off-by: Linjie Fu <linjie.fu@intel.com>
---
 libavfilter/vf_scale_qsv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

mypopy@gmail.com Jan. 21, 2020, 10:18 a.m. UTC | #1
On Tue, Jan 21, 2020 at 4:51 PM Linjie Fu <linjie.fu@intel.com> wrote:
>
> Class name is used in show_help_children(avfilter_get_class(),...)
> to prompt the available filters.
>
> $ ffmpeg -h full
>
> Before:
> qsvscale AVOptions:
>
> After:
> scale_qsv AVOptions:
>
> Signed-off-by: Linjie Fu <linjie.fu@intel.com>
> ---
>  libavfilter/vf_scale_qsv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
> index 1cf5367..d1fa942 100644
> --- a/libavfilter/vf_scale_qsv.c
> +++ b/libavfilter/vf_scale_qsv.c
> @@ -629,7 +629,7 @@ static const AVOption options[] = {
>  };
>
>  static const AVClass qsvscale_class = {
> -    .class_name = "qsvscale",
> +    .class_name = "scale_qsv",
>      .item_name  = av_default_item_name,
>      .option     = options,
>      .version    = LIBAVUTIL_VERSION_INT,
> --
> 2.7.4
>
LGTM
Fu, Linjie Feb. 15, 2020, 8:31 a.m. UTC | #2
> -----Original Message-----
> From: mypopy@gmail.com <mypopy@gmail.com>
> Sent: Tuesday, January 21, 2020 18:19
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Cc: Fu, Linjie <linjie.fu@intel.com>
> Subject: Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: fix the class_name
> in help for scale_qsv
> 
> On Tue, Jan 21, 2020 at 4:51 PM Linjie Fu <linjie.fu@intel.com> wrote:
> >
> > Class name is used in show_help_children(avfilter_get_class(),...)
> > to prompt the available filters.
> >
> > $ ffmpeg -h full
> >
> > Before:
> > qsvscale AVOptions:
> >
> > After:
> > scale_qsv AVOptions:
> >
> > Signed-off-by: Linjie Fu <linjie.fu@intel.com>
> > ---
> >  libavfilter/vf_scale_qsv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
> > index 1cf5367..d1fa942 100644
> > --- a/libavfilter/vf_scale_qsv.c
> > +++ b/libavfilter/vf_scale_qsv.c
> > @@ -629,7 +629,7 @@ static const AVOption options[] = {
> >  };
> >
> >  static const AVClass qsvscale_class = {
> > -    .class_name = "qsvscale",
> > +    .class_name = "scale_qsv",
> >      .item_name  = av_default_item_name,
> >      .option     = options,
> >      .version    = LIBAVUTIL_VERSION_INT,
> > --
> > 2.7.4
> >
> LGTM

Thanks for review and ping.
Paul B Mahol Feb. 15, 2020, noon UTC | #3
Who gonna apply this?

On 2/15/20, Fu, Linjie <linjie.fu@intel.com> wrote:
>> -----Original Message-----
>> From: mypopy@gmail.com <mypopy@gmail.com>
>> Sent: Tuesday, January 21, 2020 18:19
>> To: FFmpeg development discussions and patches <ffmpeg-
>> devel@ffmpeg.org>
>> Cc: Fu, Linjie <linjie.fu@intel.com>
>> Subject: Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: fix the
>> class_name
>> in help for scale_qsv
>>
>> On Tue, Jan 21, 2020 at 4:51 PM Linjie Fu <linjie.fu@intel.com> wrote:
>> >
>> > Class name is used in show_help_children(avfilter_get_class(),...)
>> > to prompt the available filters.
>> >
>> > $ ffmpeg -h full
>> >
>> > Before:
>> > qsvscale AVOptions:
>> >
>> > After:
>> > scale_qsv AVOptions:
>> >
>> > Signed-off-by: Linjie Fu <linjie.fu@intel.com>
>> > ---
>> >  libavfilter/vf_scale_qsv.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
>> > index 1cf5367..d1fa942 100644
>> > --- a/libavfilter/vf_scale_qsv.c
>> > +++ b/libavfilter/vf_scale_qsv.c
>> > @@ -629,7 +629,7 @@ static const AVOption options[] = {
>> >  };
>> >
>> >  static const AVClass qsvscale_class = {
>> > -    .class_name = "qsvscale",
>> > +    .class_name = "scale_qsv",
>> >      .item_name  = av_default_item_name,
>> >      .option     = options,
>> >      .version    = LIBAVUTIL_VERSION_INT,
>> > --
>> > 2.7.4
>> >
>> LGTM
>
> Thanks for review and ping.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
index 1cf5367..d1fa942 100644
--- a/libavfilter/vf_scale_qsv.c
+++ b/libavfilter/vf_scale_qsv.c
@@ -629,7 +629,7 @@  static const AVOption options[] = {
 };
 
 static const AVClass qsvscale_class = {
-    .class_name = "qsvscale",
+    .class_name = "scale_qsv",
     .item_name  = av_default_item_name,
     .option     = options,
     .version    = LIBAVUTIL_VERSION_INT,