diff mbox series

[FFmpeg-devel,v1] MAINTAINERS: add myself to the general developers list

Message ID 1587898209-31013-1-git-send-email-lance.lmwang@gmail.com
State Accepted
Commit a124f4ebff5d7784edd25c399275f241f8026338
Headers show
Series [FFmpeg-devel,v1] MAINTAINERS: add myself to the general developers list | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Lance Wang April 26, 2020, 10:50 a.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
I have actively contributed to FFmpeg in the past year and should be familiar
with the entire code base and the rules of the developers. Up to now, more than
one hundred patches have been accepted and pushed with the help of other 
developers. However, some reviewed patches have not been pushed yet, so I am
glad to request push access to the FFmpeg repository so that I can push them
by the developer rules. I think being a committer is a duty, I prefer to submit
any patch to ML for review to avoid making mistakes.

Please the core team give comments or vote for my request.

 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Marton Balint April 26, 2020, 9:44 p.m. UTC | #1
On Sun, 26 Apr 2020, lance.lmwang@gmail.com wrote:

> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> I have actively contributed to FFmpeg in the past year and should be familiar
> with the entire code base and the rules of the developers.

Then maybe could you omit v1 designators in the future? A patch without a 
version designator is usually the first version, or at least that is how 
most of the developers send patches, so I suggest you follow this as well.

Thanks,
Marton

> Up to now, more than
> one hundred patches have been accepted and pushed with the help of other 
> developers. However, some reviewed patches have not been pushed yet, so I am
> glad to request push access to the FFmpeg repository so that I can push them
> by the developer rules. I think being a committer is a duty, I prefer to submit
> any patch to ML for review to avoid making mistakes.
>
> Please the core team give comments or vote for my request.
>
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e19d1ee586..06956f8741 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -564,6 +564,7 @@ Joakim Plate
> Jun Zhao
> Kieran Kunhya
> Kirill Gavrilov
> +Limin Wang
> Martin Storsjö
> Panagiotis Issaris
> Pedro Arthur
> -- 
> 2.21.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Lance Wang April 27, 2020, 1:42 a.m. UTC | #2
On Sun, Apr 26, 2020 at 11:44:32PM +0200, Marton Balint wrote:
> 
> 
> On Sun, 26 Apr 2020, lance.lmwang@gmail.com wrote:
> 
> >From: Limin Wang <lance.lmwang@gmail.com>
> >
> >Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> >---
> >I have actively contributed to FFmpeg in the past year and should be familiar
> >with the entire code base and the rules of the developers.
> 
> Then maybe could you omit v1 designators in the future? A patch
> without a version designator is usually the first version, or at
> least that is how most of the developers send patches, so I suggest
> you follow this as well.

Got it, I'm glad to learn for the rule. Maybe it's better to add the rule
to developer document to follow.

> 
> Thanks,
> Marton
> 
> >Up to now, more than
> >one hundred patches have been accepted and pushed with the help of
> >other developers. However, some reviewed patches have not been
> >pushed yet, so I am
> >glad to request push access to the FFmpeg repository so that I can push them
> >by the developer rules. I think being a committer is a duty, I prefer to submit
> >any patch to ML for review to avoid making mistakes.
> >
> >Please the core team give comments or vote for my request.
> >
> >MAINTAINERS | 1 +
> >1 file changed, 1 insertion(+)
> >
> >diff --git a/MAINTAINERS b/MAINTAINERS
> >index e19d1ee586..06956f8741 100644
> >--- a/MAINTAINERS
> >+++ b/MAINTAINERS
> >@@ -564,6 +564,7 @@ Joakim Plate
> >Jun Zhao
> >Kieran Kunhya
> >Kirill Gavrilov
> >+Limin Wang
> >Martin Storsjö
> >Panagiotis Issaris
> >Pedro Arthur
> >-- 
> >2.21.0
> >
> >_______________________________________________
> >ffmpeg-devel mailing list
> >ffmpeg-devel@ffmpeg.org
> >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> >To unsubscribe, visit link above, or email
> >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Michael Niedermayer April 29, 2020, 3:08 p.m. UTC | #3
On Sun, Apr 26, 2020 at 06:50:09PM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> I have actively contributed to FFmpeg in the past year and should be familiar
> with the entire code base and the rules of the developers. Up to now, more than
> one hundred patches have been accepted and pushed with the help of other 
> developers. However, some reviewed patches have not been pushed yet, so I am
> glad to request push access to the FFmpeg repository so that I can push them
> by the developer rules. I think being a committer is a duty, I prefer to submit
> any patch to ML for review to avoid making mistakes.
> 
> Please the core team give comments or vote for my request.
> 
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)

Will apply

thanks

[...]
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index e19d1ee586..06956f8741 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -564,6 +564,7 @@  Joakim Plate
 Jun Zhao
 Kieran Kunhya
 Kirill Gavrilov
+Limin Wang
 Martin Storsjö
 Panagiotis Issaris
 Pedro Arthur