diff mbox series

[FFmpeg-devel,v2,1/3] avformat/rtspdec: av_dict_set() -> av_dict_set_int()

Message ID 1590577847-24670-1-git-send-email-lance.lmwang@gmail.com
State Accepted
Headers show
Series [FFmpeg-devel,v2,1/3] avformat/rtspdec: av_dict_set() -> av_dict_set_int() | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Lance Wang May 27, 2020, 11:10 a.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavformat/rtspdec.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Lance Wang June 1, 2020, 1:55 p.m. UTC | #1 
On Wed, May 27, 2020 at 07:10:45PM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavformat/rtspdec.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c
> index bd2e8f4..dfa2991 100644
> --- a/libavformat/rtspdec.c
> +++ b/libavformat/rtspdec.c
> @@ -289,9 +289,7 @@ static int rtsp_read_setup(AVFormatContext *s, char* host, char *controlurl)
>      } else {
>          do {
>              AVDictionary *opts = NULL;
> -            char buf[256];
> -            snprintf(buf, sizeof(buf), "%d", rt->buffer_size);
> -            av_dict_set(&opts, "buffer_size", buf, 0);
> +            av_dict_set_int(&opts, "buffer_size", rt->buffer_size, 0);
>              ff_url_join(url, sizeof(url), "rtp", NULL, host, localport, NULL);
>              av_log(s, AV_LOG_TRACE, "Opening: %s", url);
>              ret = ffurl_open_whitelist(&rtsp_st->rtp_handle, url, AVIO_FLAG_READ_WRITE,
> -- 
> 1.8.3.1
> 

will apply the patchset tomorrow if no further comments.
diff mbox series

Patch

diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c
index bd2e8f4..dfa2991 100644
--- a/libavformat/rtspdec.c
+++ b/libavformat/rtspdec.c
@@ -289,9 +289,7 @@  static int rtsp_read_setup(AVFormatContext *s, char* host, char *controlurl)
     } else {
         do {
             AVDictionary *opts = NULL;
-            char buf[256];
-            snprintf(buf, sizeof(buf), "%d", rt->buffer_size);
-            av_dict_set(&opts, "buffer_size", buf, 0);
+            av_dict_set_int(&opts, "buffer_size", rt->buffer_size, 0);
             ff_url_join(url, sizeof(url), "rtp", NULL, host, localport, NULL);
             av_log(s, AV_LOG_TRACE, "Opening: %s", url);
             ret = ffurl_open_whitelist(&rtsp_st->rtp_handle, url, AVIO_FLAG_READ_WRITE,