diff mbox series

[FFmpeg-devel,5/6] avformat/aviobuf: INT_MAX -> AV_BPRINT_SIZE_UNLIMITED

Message ID 1593132446-21202-5-git-send-email-lance.lmwang@gmail.com
State New
Headers show
Series [FFmpeg-devel,1/6] avcodec/dvbsubdec: simplify code by using OFFSET() macro
Related show

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Limin Wang June 26, 2020, 12:47 a.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavformat/aviobuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Rheinhardt June 26, 2020, 3:16 a.m. UTC | #1
lance.lmwang@gmail.com:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavformat/aviobuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c
> index a77517d..1e32c0c 100644
> --- a/libavformat/aviobuf.c
> +++ b/libavformat/aviobuf.c
> @@ -1191,7 +1191,7 @@ int avio_printf(AVIOContext *s, const char *fmt, ...)
>      va_list ap;
>      AVBPrint bp;
>  
> -    av_bprint_init(&bp, 0, INT_MAX);
> +    av_bprint_init(&bp, 0, AV_BPRINT_SIZE_UNLIMITED);
>      va_start(ap, fmt);
>      av_vbprintf(&bp, fmt, ap);
>      va_end(ap);
> 
This function returns an int containing either the number of bytes
written or an error code. Ergo the number of bytes written must be in
the range 0..INT_MAX.

- Andreas
Limin Wang June 26, 2020, 9:12 a.m. UTC | #2
On Fri, Jun 26, 2020 at 05:16:03AM +0200, Andreas Rheinhardt wrote:
> lance.lmwang@gmail.com:
> > From: Limin Wang <lance.lmwang@gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  libavformat/aviobuf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c
> > index a77517d..1e32c0c 100644
> > --- a/libavformat/aviobuf.c
> > +++ b/libavformat/aviobuf.c
> > @@ -1191,7 +1191,7 @@ int avio_printf(AVIOContext *s, const char *fmt, ...)
> >      va_list ap;
> >      AVBPrint bp;
> >  
> > -    av_bprint_init(&bp, 0, INT_MAX);
> > +    av_bprint_init(&bp, 0, AV_BPRINT_SIZE_UNLIMITED);
> >      va_start(ap, fmt);
> >      av_vbprintf(&bp, fmt, ap);
> >      va_end(ap);
> > 
> This function returns an int containing either the number of bytes
> written or an error code. Ergo the number of bytes written must be in
> the range 0..INT_MAX.

Yes, please ignore the change.

> 
> - Andreas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c
index a77517d..1e32c0c 100644
--- a/libavformat/aviobuf.c
+++ b/libavformat/aviobuf.c
@@ -1191,7 +1191,7 @@  int avio_printf(AVIOContext *s, const char *fmt, ...)
     va_list ap;
     AVBPrint bp;
 
-    av_bprint_init(&bp, 0, INT_MAX);
+    av_bprint_init(&bp, 0, AV_BPRINT_SIZE_UNLIMITED);
     va_start(ap, fmt);
     av_vbprintf(&bp, fmt, ap);
     va_end(ap);