diff mbox series

[FFmpeg-devel,1/6] avformat/rtsp: 16384 -> SDP_MAX_SIZE

Message ID 1604497047-30429-1-git-send-email-lance.lmwang@gmail.com
State Accepted
Commit 54394600169c5c91aa6de9d555a04b865165407e
Headers show
Series [FFmpeg-devel,1/6] avformat/rtsp: 16384 -> SDP_MAX_SIZE | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished

Commit Message

Limin Wang Nov. 4, 2020, 1:37 p.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavformat/rtsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhao Zhili Nov. 9, 2020, 2:51 p.m. UTC | #1
> On Nov 4, 2020, at 9:37 PM, lance.lmwang@gmail.com wrote:
> 
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavformat/rtsp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index 49c2d52..1b876c9 100644
> --- a/libavformat/rtsp.c
> +++ b/libavformat/rtsp.c
> @@ -696,7 +696,7 @@ int ff_sdp_parse(AVFormatContext *s, const char *content)
>      *
>      * The Vorbis FMTP line can be up to 16KB - see xiph_parse_sdp_line
>      * in rtpdec_xiph.c. */
> -    char buf[16384], *q;
> +    char buf[SDP_MAX_SIZE], *q;

The comments before this line should be moved to where SDP_MAX_SIZE
is defined.

>     SDPParseState sdp_parse_state = { { 0 } }, *s1 = &sdp_parse_state;
> 
>     p = content;
> -- 
> 1.8.3.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Limin Wang Nov. 10, 2020, 12:57 a.m. UTC | #2
On Mon, Nov 09, 2020 at 10:51:05PM +0800, Zhao Zhili wrote:
> 
> 
> > On Nov 4, 2020, at 9:37 PM, lance.lmwang@gmail.com wrote:
> > 
> > From: Limin Wang <lance.lmwang@gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> > libavformat/rtsp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> > index 49c2d52..1b876c9 100644
> > --- a/libavformat/rtsp.c
> > +++ b/libavformat/rtsp.c
> > @@ -696,7 +696,7 @@ int ff_sdp_parse(AVFormatContext *s, const char *content)
> >      *
> >      * The Vorbis FMTP line can be up to 16KB - see xiph_parse_sdp_line
> >      * in rtpdec_xiph.c. */
> > -    char buf[16384], *q;
> > +    char buf[SDP_MAX_SIZE], *q;
> 
> The comments before this line should be moved to where SDP_MAX_SIZE
> is defined.

Yes, I have noticed the comments also, but SDP_MAX_SIZE is more general usage
for rtpdec and rtpenc, so I don't think 16KB is necessary for Vorbis only. 
I prefer to remove the comments and keep the log in comment message. 

> 
> >     SDPParseState sdp_parse_state = { { 0 } }, *s1 = &sdp_parse_state;
> > 
> >     p = content;
> > -- 
> > 1.8.3.1
> > 
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > 
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 49c2d52..1b876c9 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -696,7 +696,7 @@  int ff_sdp_parse(AVFormatContext *s, const char *content)
      *
      * The Vorbis FMTP line can be up to 16KB - see xiph_parse_sdp_line
      * in rtpdec_xiph.c. */
-    char buf[16384], *q;
+    char buf[SDP_MAX_SIZE], *q;
     SDPParseState sdp_parse_state = { { 0 } }, *s1 = &sdp_parse_state;
 
     p = content;