diff mbox series

[FFmpeg-devel,5/8] avformat/mov: support dvwC box for Dolby Vision

Message ID 1634216942-20329-5-git-send-email-lance.lmwang@gmail.com
State Accepted
Commit 3c3ef41593821aa8386e4467fb0397e16c928d29
Headers show
Series [FFmpeg-devel,1/8] avfilter/af_replaygain: use fabsf() instead of fabs()
Related show

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Limin Wang Oct. 14, 2021, 1:08 p.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

By <<Dolby Vision Streams Within the ISO Base Media File Format Version 2.2>>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavformat/mov.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

mypopy@gmail.com Oct. 15, 2021, 8:40 a.m. UTC | #1
On Thu, Oct 14, 2021 at 9:10 PM <lance.lmwang@gmail.com> wrote:
>
> From: Limin Wang <lance.lmwang@gmail.com>
>
> By <<Dolby Vision Streams Within the ISO Base Media File Format Version 2.2>>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavformat/mov.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 57c67e3..49a8c27 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -7074,7 +7074,7 @@ static int mov_read_dvcc_dvvc(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>          return ret;
>      }
>
> -    av_log(c, AV_LOG_TRACE, "DOVI in dvcC/dvvC box, version: %d.%d, profile: %d, level: %d, "
> +    av_log(c, AV_LOG_TRACE, "DOVI in dvcC/dvvC/dvwC box, version: %d.%d, profile: %d, level: %d, "
>             "rpu flag: %d, el flag: %d, bl flag: %d, compatibility id: %d\n",
>             dovi->dv_version_major, dovi->dv_version_minor,
>             dovi->dv_profile, dovi->dv_level,
> @@ -7273,6 +7273,7 @@ static const MOVParseTableEntry mov_default_parse_table[] = {
>  { MKTAG('c','l','l','i'), mov_read_clli },
>  { MKTAG('d','v','c','C'), mov_read_dvcc_dvvc },
>  { MKTAG('d','v','v','C'), mov_read_dvcc_dvvc },
> +{ MKTAG('d','v','w','C'), mov_read_dvcc_dvvc },
>  { MKTAG('k','i','n','d'), mov_read_kind },
>  { 0, NULL }
>  };
> --
> 1.8.3.1
Do you have test clip for this patch?
Limin Wang Oct. 15, 2021, 1:56 p.m. UTC | #2
On Fri, Oct 15, 2021 at 04:40:26PM +0800, mypopy@gmail.com wrote:
> On Thu, Oct 14, 2021 at 9:10 PM <lance.lmwang@gmail.com> wrote:
> >
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > By <<Dolby Vision Streams Within the ISO Base Media File Format Version 2.2>>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  libavformat/mov.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/mov.c b/libavformat/mov.c
> > index 57c67e3..49a8c27 100644
> > --- a/libavformat/mov.c
> > +++ b/libavformat/mov.c
> > @@ -7074,7 +7074,7 @@ static int mov_read_dvcc_dvvc(MOVContext *c, AVIOContext *pb, MOVAtom atom)
> >          return ret;
> >      }
> >
> > -    av_log(c, AV_LOG_TRACE, "DOVI in dvcC/dvvC box, version: %d.%d, profile: %d, level: %d, "
> > +    av_log(c, AV_LOG_TRACE, "DOVI in dvcC/dvvC/dvwC box, version: %d.%d, profile: %d, level: %d, "
> >             "rpu flag: %d, el flag: %d, bl flag: %d, compatibility id: %d\n",
> >             dovi->dv_version_major, dovi->dv_version_minor,
> >             dovi->dv_profile, dovi->dv_level,
> > @@ -7273,6 +7273,7 @@ static const MOVParseTableEntry mov_default_parse_table[] = {
> >  { MKTAG('c','l','l','i'), mov_read_clli },
> >  { MKTAG('d','v','c','C'), mov_read_dvcc_dvvc },
> >  { MKTAG('d','v','v','C'), mov_read_dvcc_dvvc },
> > +{ MKTAG('d','v','w','C'), mov_read_dvcc_dvvc },
> >  { MKTAG('k','i','n','d'), mov_read_kind },
> >  { 0, NULL }
> >  };
> > --
> > 1.8.3.1
> Do you have test clip for this patch?

I tested with created sample with the mov muxer in the patchset. I haven't saw such
sample released by dolby.
diff mbox series

Patch

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 57c67e3..49a8c27 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -7074,7 +7074,7 @@  static int mov_read_dvcc_dvvc(MOVContext *c, AVIOContext *pb, MOVAtom atom)
         return ret;
     }
 
-    av_log(c, AV_LOG_TRACE, "DOVI in dvcC/dvvC box, version: %d.%d, profile: %d, level: %d, "
+    av_log(c, AV_LOG_TRACE, "DOVI in dvcC/dvvC/dvwC box, version: %d.%d, profile: %d, level: %d, "
            "rpu flag: %d, el flag: %d, bl flag: %d, compatibility id: %d\n",
            dovi->dv_version_major, dovi->dv_version_minor,
            dovi->dv_profile, dovi->dv_level,
@@ -7273,6 +7273,7 @@  static const MOVParseTableEntry mov_default_parse_table[] = {
 { MKTAG('c','l','l','i'), mov_read_clli },
 { MKTAG('d','v','c','C'), mov_read_dvcc_dvvc },
 { MKTAG('d','v','v','C'), mov_read_dvcc_dvvc },
+{ MKTAG('d','v','w','C'), mov_read_dvcc_dvvc },
 { MKTAG('k','i','n','d'), mov_read_kind },
 { 0, NULL }
 };