| Message ID | 20160906032628.71847-2-rodger.combs@gmail.com |
|---|---|
| State | Accepted |
| Commit | 3829a02738c16cfc84f41fd4b55a34c03386a65b |
| Headers | show |
2016-09-06 5:26 GMT+02:00 Rodger Combs <rodger.combs@gmail.com>: > --- > libavformat/matroskaenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index decb66d..7deccaa 100644 > --- a/libavformat/matroskaenc.c > +++ b/libavformat/matroskaenc.c > @@ -1314,6 +1314,7 @@ static int mkv_check_tag_name(const char *name, unsigned int elementid) > av_strcasecmp(name, "stereo_mode") && > av_strcasecmp(name, "creation_time") && > av_strcasecmp(name, "encoding_tool") && > + av_strcasecmp(name, "duration") && Could you elaborate? Carl Eugen
> On Sep 6, 2016, at 05:10, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > > 2016-09-06 5:26 GMT+02:00 Rodger Combs <rodger.combs@gmail.com>: >> --- >> libavformat/matroskaenc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c >> index decb66d..7deccaa 100644 >> --- a/libavformat/matroskaenc.c >> +++ b/libavformat/matroskaenc.c >> @@ -1314,6 +1314,7 @@ static int mkv_check_tag_name(const char *name, unsigned int elementid) >> av_strcasecmp(name, "stereo_mode") && >> av_strcasecmp(name, "creation_time") && >> av_strcasecmp(name, "encoding_tool") && >> + av_strcasecmp(name, "duration") && > > Could you elaborate? > > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel 31852540 and 70c1647a add support for writing durations in the native matroska format. In the case of the global duration, this reads the value out of metadata when present (so writing it there as well would be redundant) and the metadata "duration" value in an actual MKV isn't read by anything anyway; for the stream durations, they're written as tags, so writing one from the metadata dict as well would create duplicate keys.
On Mon, Sep 05, 2016 at 10:26:27PM -0500, Rodger Combs wrote: > --- > libavformat/matroskaenc.c | 1 + > 1 file changed, 1 insertion(+) no objection from me [...]
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index decb66d..7deccaa 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -1314,6 +1314,7 @@ static int mkv_check_tag_name(const char *name, unsigned int elementid) av_strcasecmp(name, "stereo_mode") && av_strcasecmp(name, "creation_time") && av_strcasecmp(name, "encoding_tool") && + av_strcasecmp(name, "duration") && (elementid != MATROSKA_ID_TAGTARGETS_TRACKUID || av_strcasecmp(name, "language")); }