diff mbox

[FFmpeg-devel] ffmpeg_opt: Suggest to use "file:..." if a protocol was not found

Message ID 201609061251.05137.cehoyos@ag.or.at
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos Sept. 6, 2016, 10:51 a.m. UTC
Hi!

Attached patch tries to fix Debian bug 785690.

Please comment, Carl Eugen

Comments

Michael Niedermayer Sept. 6, 2016, 10:57 a.m. UTC | #1
On Tue, Sep 06, 2016 at 12:51:05PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch tries to fix Debian bug 785690.
> 
> Please comment, Carl Eugen

>  ffmpeg_opt.c |    2 ++
>  1 file changed, 2 insertions(+)
> 7ea4c9b62c1fa94707e3d88143bb2df73cf501c6  0001-ffmpeg_opt-Suggest-to-use-file-.-if-a-protocol-was-n.patch
> From fd0391ac4cefffe15da42ac1e14aafc5b3a9dbaf Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <cehoyos@ag.or.at>
> Date: Tue, 6 Sep 2016 12:47:34 +0200
> Subject: [PATCH] ffmpeg_opt: Suggest to use "file:..." if a protocol was not
>  found.
> 
> Fixes Debian bug 785690.
> ---
>  ffmpeg_opt.c |    2 ++
>  1 file changed, 2 insertions(+)

LGTM

please give others a day to comment before applying

thx

[...]
Carl Eugen Hoyos Sept. 7, 2016, 4:52 p.m. UTC | #2
2016-09-06 12:57 GMT+02:00 Michael Niedermayer <michael@niedermayer.cc>:
>> Subject: [PATCH] ffmpeg_opt: Suggest to use "file:..." if a
>> protocol was not found.
>>
>> Fixes Debian bug 785690.
>> ---
>>  ffmpeg_opt.c |    2 ++
>>  1 file changed, 2 insertions(+)
>
> LGTM
>
> please give others a day to comment before applying

Patch applied.

Thank you, Carl Eugen
diff mbox

Patch

From fd0391ac4cefffe15da42ac1e14aafc5b3a9dbaf Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <cehoyos@ag.or.at>
Date: Tue, 6 Sep 2016 12:47:34 +0200
Subject: [PATCH] ffmpeg_opt: Suggest to use "file:..." if a protocol was not
 found.

Fixes Debian bug 785690.
---
 ffmpeg_opt.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c
index 2ea09cf..0c0d3a6 100644
--- a/ffmpeg_opt.c
+++ b/ffmpeg_opt.c
@@ -982,6 +982,8 @@  static int open_input_file(OptionsContext *o, const char *filename)
     err = avformat_open_input(&ic, filename, file_iformat, &o->g->format_opts);
     if (err < 0) {
         print_error(filename, err);
+        if (err == AVERROR_PROTOCOL_NOT_FOUND)
+            av_log(NULL, AV_LOG_ERROR, "Did you mean file:%s?\n", filename);
         exit_program(1);
     }
     if (scan_all_pmts_set)
-- 
1.7.10.4