[FFmpeg-devel] ffmpeg: switch to codecpar

On Tue, Sep 20, 2016 at 12:28:41PM +0200, Clément Bœsch wrote:
> From: Clément Bœsch <clement@stupeflix.com>
> 
> This commit is largely based on commit 15e84ed3 from Anton Khirnov
> <anton@khirnov.net> which was previously skipped in bbf5ef9d.
> 
> There are still a bunch of things raising codecpar related warnings that
> need fixing, such as:
> - the use of codec->debug in the interactive debug mode
> - read_ffserver_streams(): it's probably broken now but there is no test
> - lowres stuff
> - codec copy apparently required by bitstream filters
> 
> The matroska references are updated because they now properly forward
> the field_order (previously unknown, now progressive).
> 
> Thanks to James Almer for fixing a bunch of FATE issues in this commit.
> 
> Signed-off-by: Clément Bœsch <clement@stupeflix.com>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  cmdutils.c          |   4 +-
>  ffmpeg.c            | 246 +++++++++++++++++++++++++++++-----------------------
>  ffmpeg.h            |   1 +
>  ffmpeg_filter.c     |  24 ++---
>  ffmpeg_opt.c        | 140 +++++++++++++++++-------------
>  libavformat/utils.c |   2 +-
>  tests/ref/lavf/mkv  |   4 +-
>  7 files changed, 237 insertions(+), 184 deletions(-)

breaks fate-rgb24-mkv

IIRC i saw some difference with mkvinfo yesterdady related to
interlacing

Test rgb24-mkv failed. Look at tests/data/fate/rgb24-mkv.err for details.
make: *** [fate-rgb24-mkv] Error 1
make: *** Waiting for unfinished jobs....

[...]

On Tue, Sep 20, 2016 at 01:53:05PM +0200, Michael Niedermayer wrote:
> On Tue, Sep 20, 2016 at 12:28:41PM +0200, Clément Bœsch wrote:
> > From: Clément Bœsch <clement@stupeflix.com>
> > 
> > This commit is largely based on commit 15e84ed3 from Anton Khirnov
> > <anton@khirnov.net> which was previously skipped in bbf5ef9d.
> > 
> > There are still a bunch of things raising codecpar related warnings that
> > need fixing, such as:
> > - the use of codec->debug in the interactive debug mode
> > - read_ffserver_streams(): it's probably broken now but there is no test
> > - lowres stuff
> > - codec copy apparently required by bitstream filters
> > 
> > The matroska references are updated because they now properly forward
> > the field_order (previously unknown, now progressive).
> > 
> > Thanks to James Almer for fixing a bunch of FATE issues in this commit.
> > 
> > Signed-off-by: Clément Bœsch <clement@stupeflix.com>
> > Signed-off-by: James Almer <jamrial@gmail.com>
> > ---
> >  cmdutils.c          |   4 +-
> >  ffmpeg.c            | 246 +++++++++++++++++++++++++++++-----------------------
> >  ffmpeg.h            |   1 +
> >  ffmpeg_filter.c     |  24 ++---
> >  ffmpeg_opt.c        | 140 +++++++++++++++++-------------
> >  libavformat/utils.c |   2 +-
> >  tests/ref/lavf/mkv  |   4 +-
> >  7 files changed, 237 insertions(+), 184 deletions(-)
> 
> breaks fate-rgb24-mkv
> 
> IIRC i saw some difference with mkvinfo yesterdady related to
> interlacing
> 
> --- ./tests/ref/fate/rgb24-mkv  2016-09-20 13:44:14.413175330 +0200
> +++ tests/data/fate/rgb24-mkv   2016-09-20 13:48:58.381181313 +0200
> @@ -1,4 +1,4 @@
> -4765774ab65412c9b7565b1b4da82998 *tests/data/fate/rgb24-mkv.matroska
> +0d081c8e151a922435830f95000d3c71 *tests/data/fate/rgb24-mkv.matroska
>  58321 tests/data/fate/rgb24-mkv.matroska
>  #tb 0: 1/10
>  #media_type 0: video
> Test rgb24-mkv failed. Look at tests/data/fate/rgb24-mkv.err for details.
> make: *** [fate-rgb24-mkv] Error 1
> make: *** Waiting for unfinished jobs....
> 

This is the exact same failure as the two other tests changed in this
patch: the interlaced information now stores progressive (value=2) instead
of unknown (value=0). Fate reference updated locally to reflect this
change to this test as well.