| Message ID | 201609240000.35942.cehoyos@ag.or.at |
|---|---|
| State | Accepted |
| Headers | show |
On Sat, 24 Sep 2016 00:00:35 +0200 Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: > Hi! > > I use this patch locally for some time. It fixes > many misdetections, a similar patch was applied to > loas detection three years ago. > An alternative would be to return "1" for two frames. this prevents all of those files from trying to be decoded as aac ? if so, good. -compn
Hi, On Fri, Sep 23, 2016 at 6:00 PM, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote: > Hi! > > I use this patch locally for some time. It fixes > many misdetections, a similar patch was applied to > loas detection three years ago. > An alternative would be to return "1" for two frames. Is there any point in detecting two AAC frames? I mean, we're talking about a split second audio... I think the patch as-is is fine. Ronald
diff --git a/libavformat/aacdec.c b/libavformat/aacdec.c index aa23756..39624e4 100644 --- a/libavformat/aacdec.c +++ b/libavformat/aacdec.c @@ -70,8 +70,6 @@ static int adts_aac_probe(AVProbeData *p) return AVPROBE_SCORE_EXTENSION; else if (max_frames >= 3) return AVPROBE_SCORE_EXTENSION / 2; - else if (max_frames >= 1) - return 1; else return 0; }
Hi! I use this patch locally for some time. It fixes many misdetections, a similar patch was applied to loas detection three years ago. An alternative would be to return "1" for two frames. Please comment, Carl Eugen From f3d9ebedcbc137c4d639efdbed485298f9dc9f3e Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos <cehoyos@ag.or.at> Date: Fri, 23 Sep 2016 23:57:03 +0200 Subject: [PATCH] lavf/aacdec: Do not autodetect a single frame. --- libavformat/aacdec.c | 2 -- 1 file changed, 2 deletions(-)