diff mbox

[FFmpeg-devel] added possibility to set first to ninth audio language for RIFF taged files (e.g. avi files)

Message ID 20161002170105.8236-1-floriandiemer@gmx.net
State Accepted
Commit db4c1bee9620fb001fd7817a08c0f458c00b7811
Headers show

Commit Message

floriandiemer@gmx.net Oct. 2, 2016, 5:01 p.m. UTC
---
Sorry but the first patch was improperly formatted.


According to this page (http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/RIFF.html#Info) it is possible
to add language information ("IAS1" (first language) to "IAS9" (ninth language)) to RIFF tagged files (as RIFF Info Tags).
Programs such as VLC media player or MediaInfo can properly read and display this information. Allowing to set this tags
with the -metadata option while encoding, would simplify the process.
---
 libavformat/riffenc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Michael Niedermayer Oct. 5, 2016, 9:37 p.m. UTC | #1
On Sun, Oct 02, 2016 at 07:01:05PM +0200, Florian Diemer wrote:
> ---
> Sorry but the first patch was improperly formatted.
> 
> 
> According to this page (http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/RIFF.html#Info) it is possible
> to add language information ("IAS1" (first language) to "IAS9" (ninth language)) to RIFF tagged files (as RIFF Info Tags).
> Programs such as VLC media player or MediaInfo can properly read and display this information. Allowing to set this tags
> with the -metadata option while encoding, would simplify the process.
> ---
>  libavformat/riffenc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

applied

thx

[...]
diff mbox

Patch

diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c
index 36e6ac7..4b25c06 100644
--- a/libavformat/riffenc.c
+++ b/libavformat/riffenc.c
@@ -304,7 +304,8 @@  void ff_riff_write_info_tag(AVIOContext *pb, const char *tag, const char *str)
 }
 
 static const char riff_tags[][5] = {
-    "IARL", "IART", "ICMS", "ICMT", "ICOP", "ICRD", "ICRP", "IDIM", "IDPI",
+    "IARL", "IART", "IAS1", "IAS2", "IAS3", "IAS4", "IAS5", "IAS6", "IAS7",
+    "IAS8", "IAS9", "ICMS", "ICMT", "ICOP", "ICRD", "ICRP", "IDIM", "IDPI",
     "IENG", "IGNR", "IKEY", "ILGT", "ILNG", "IMED", "INAM", "IPLT", "IPRD",
     "IPRT", "ITRK", "ISBJ", "ISFT", "ISHP", "ISMP", "ISRC", "ISRF", "ITCH",
     { 0 }