diff mbox

[FFmpeg-devel,1/2] avcodec/mjpegenc_huffman: Assert length in ff_mjpegenc_huffman_compute_bits()

Message ID 20170408013445.5331-1-michael@niedermayer.cc
State Accepted
Commit 8dd0c12648d838bb982ca10f384ee1f0107dfece
Headers show

Commit Message

Michael Niedermayer April 8, 2017, 1:34 a.m. UTC 
This should help coverity see that the issues this leads to cannot occur

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/mjpegenc_huffman.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Niedermayer April 10, 2017, 11:12 a.m. UTC | #1 
On Sat, Apr 08, 2017 at 03:34:44AM +0200, Michael Niedermayer wrote:
> This should help coverity see that the issues this leads to cannot occur
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/mjpegenc_huffman.c | 2 ++
>  1 file changed, 2 insertions(+)

applied

[...]
diff mbox

Patch

diff --git a/libavcodec/mjpegenc_huffman.c b/libavcodec/mjpegenc_huffman.c
index ebf1311466..0e63f8066b 100644
--- a/libavcodec/mjpegenc_huffman.c
+++ b/libavcodec/mjpegenc_huffman.c
@@ -87,6 +87,8 @@  void ff_mjpegenc_huffman_compute_bits(PTable *prob_table, HuffTable *distincts,
 
     int min;
 
+    av_assert0(max_length > 0);
+
     to->nitems = 0;
     from->nitems = 0;
     to->item_idx[0] = 0;