diff mbox

[FFmpeg-devel] lavc/aarch64/simple_idct: fix idct_col4_top coefficient

Message ID 20170613152421.31464-1-matthieu.bouron@gmail.com
State Accepted
Commit 8aa60606fb64b8280627935b0df55d4d2aeca5d1
Headers show

Commit Message

Matthieu Bouron June 13, 2017, 3:24 p.m. UTC 
Fixes regression introduced by 5d0b8b1ae307951310c7d9a8fa282fbca9b997cd.
---
 libavcodec/aarch64/simple_idct_neon.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Clément Bœsch June 13, 2017, 3:26 p.m. UTC | #1 
On Tue, Jun 13, 2017 at 05:24:21PM +0200, Matthieu Bouron wrote:
> Fixes regression introduced by 5d0b8b1ae307951310c7d9a8fa282fbca9b997cd.
> ---
>  libavcodec/aarch64/simple_idct_neon.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/aarch64/simple_idct_neon.S b/libavcodec/aarch64/simple_idct_neon.S
> index 92987985d2..5bd31e5be9 100644
> --- a/libavcodec/aarch64/simple_idct_neon.S
> +++ b/libavcodec/aarch64/simple_idct_neon.S
> @@ -74,7 +74,7 @@ endconst
>  .endm
>  
>  .macro idct_col4_top y1, y2, y3, y4, i, l
> -        smull\i         v7.4S,  \y3\l, z1
> +        smull\i         v7.4S,  \y3\l, z2
>          smull\i         v16.4S, \y3\l, z6
>          smull\i         v17.4S, \y2\l, z1
>          add             v19.4S, v23.4S, v7.4S

LGTM
Matthieu Bouron June 13, 2017, 3:50 p.m. UTC | #2 
On Tue, Jun 13, 2017 at 05:26:43PM +0200, Clément Bœsch wrote:
> On Tue, Jun 13, 2017 at 05:24:21PM +0200, Matthieu Bouron wrote:
> > Fixes regression introduced by 5d0b8b1ae307951310c7d9a8fa282fbca9b997cd.
> > ---
> >  libavcodec/aarch64/simple_idct_neon.S | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/aarch64/simple_idct_neon.S b/libavcodec/aarch64/simple_idct_neon.S
> > index 92987985d2..5bd31e5be9 100644
> > --- a/libavcodec/aarch64/simple_idct_neon.S
> > +++ b/libavcodec/aarch64/simple_idct_neon.S
> > @@ -74,7 +74,7 @@ endconst
> >  .endm
> >  
> >  .macro idct_col4_top y1, y2, y3, y4, i, l
> > -        smull\i         v7.4S,  \y3\l, z1
> > +        smull\i         v7.4S,  \y3\l, z2
> >          smull\i         v16.4S, \y3\l, z6
> >          smull\i         v17.4S, \y2\l, z1
> >          add             v19.4S, v23.4S, v7.4S
> 
> LGTM

Patch applied and backported to the 3.3 branch.

Thanks.
diff mbox

Patch

diff --git a/libavcodec/aarch64/simple_idct_neon.S b/libavcodec/aarch64/simple_idct_neon.S
index 92987985d2..5bd31e5be9 100644
--- a/libavcodec/aarch64/simple_idct_neon.S
+++ b/libavcodec/aarch64/simple_idct_neon.S
@@ -74,7 +74,7 @@  endconst
 .endm
 
 .macro idct_col4_top y1, y2, y3, y4, i, l
-        smull\i         v7.4S,  \y3\l, z1
+        smull\i         v7.4S,  \y3\l, z2
         smull\i         v16.4S, \y3\l, z6
         smull\i         v17.4S, \y2\l, z1
         add             v19.4S, v23.4S, v7.4S