diff mbox

[FFmpeg-devel,2/3] avcodec/takdec: Fix integer overflow in decode_lpc()

Message ID 20170922184528.24322-2-michael@niedermayer.cc
State Accepted
Commit 5d31f03a0264cac24434c8108daef4ccba6d28f9
Headers show

Commit Message

Michael Niedermayer Sept. 22, 2017, 6:45 p.m. UTC 
Fixes: runtime error: signed integer overflow: 16748560 + 2143729712 cannot be represented in type 'int'
Fixes: 3202/clusterfuzz-testcase-minimized-4988291642294272

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/takdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c
index 9c253c1e8e..0439a3ac9b 100644
--- a/libavcodec/takdec.c
+++ b/libavcodec/takdec.c
@@ -206,7 +206,7 @@  static void decode_lpc(int32_t *coeffs, int mode, int length)
         unsigned a1 = *coeffs++;
         for (i = 0; i < length - 1 >> 1; i++) {
             *coeffs   += a1;
-            coeffs[1] += *coeffs;
+            coeffs[1] += (unsigned)*coeffs;
             a1         = coeffs[1];
             coeffs    += 2;
         }