diff mbox

[FFmpeg-devel,2/2] avformat/mov_esds: check return value of ff_mp4_read_dec_config_descr

Message ID 20171125185457.6860-2-jamrial@gmail.com
State Accepted
Commit abf669479c0098ab5eb184a167e57a70aabb942b
Headers show

Commit Message

James Almer Nov. 25, 2017, 6:54 p.m. UTC 
Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/mov_esds.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Michael Niedermayer Nov. 26, 2017, 2:09 a.m. UTC | #1 
On Sat, Nov 25, 2017 at 03:54:57PM -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavformat/mov_esds.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

should be ok

thx

[...]
James Almer Nov. 26, 2017, 2:16 a.m. UTC | #2 
On 11/25/2017 11:09 PM, Michael Niedermayer wrote:
> On Sat, Nov 25, 2017 at 03:54:57PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  libavformat/mov_esds.c | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> should be ok
> 
> thx

Pushed, thanks.
diff mbox

Patch

diff --git a/libavformat/mov_esds.c b/libavformat/mov_esds.c
index 2ecf03742f..a444d969c6 100644
--- a/libavformat/mov_esds.c
+++ b/libavformat/mov_esds.c
@@ -23,7 +23,7 @@ 
 int ff_mov_read_esds(AVFormatContext *fc, AVIOContext *pb)
 {
     AVStream *st;
-    int tag;
+    int tag, ret = 0;
 
     if (fc->nb_streams < 1)
         return 0;
@@ -38,6 +38,7 @@  int ff_mov_read_esds(AVFormatContext *fc, AVIOContext *pb)
 
     ff_mp4_read_descr(fc, pb, &tag);
     if (tag == MP4DecConfigDescrTag)
-        ff_mp4_read_dec_config_descr(fc, st, pb);
-    return 0;
+        ret = ff_mp4_read_dec_config_descr(fc, st, pb);
+
+    return ret;
 }