diff mbox

[FFmpeg-devel,6/6] psmf: add FATE tests

Message ID 20171225022834.33865-7-misty@brew.sh
State Superseded
Headers show

Commit Message

misty@brew.sh Dec. 25, 2017, 2:28 a.m. UTC
From: Misty De Meo <mistydemeo@gmail.com>

---
 tests/Makefile      |  1 +
 tests/fate/psmf.mak | 23 +++++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 tests/fate/psmf.mak

Comments

Michael Niedermayer Dec. 25, 2017, 11:27 p.m. UTC | #1
On Mon, Dec 25, 2017 at 10:28:34AM +0800, misty@brew.sh wrote:
> From: Misty De Meo <mistydemeo@gmail.com>
> 
> ---
>  tests/Makefile      |  1 +
>  tests/fate/psmf.mak | 23 +++++++++++++++++++++++
>  2 files changed, 24 insertions(+)
>  create mode 100644 tests/fate/psmf.mak
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index fd3713fe81..c569091fcb 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -165,6 +165,7 @@ include $(SRC_PATH)/tests/fate/pcm.mak
>  include $(SRC_PATH)/tests/fate/pixlet.mak
>  include $(SRC_PATH)/tests/fate/probe.mak
>  include $(SRC_PATH)/tests/fate/prores.mak
> +include $(SRC_PATH)/tests/fate/psmf.mak
>  include $(SRC_PATH)/tests/fate/qt.mak
>  include $(SRC_PATH)/tests/fate/qtrle.mak
>  include $(SRC_PATH)/tests/fate/real.mak
> diff --git a/tests/fate/psmf.mak b/tests/fate/psmf.mak
> new file mode 100644
> index 0000000000..0d83daad49
> --- /dev/null
> +++ b/tests/fate/psmf.mak
> @@ -0,0 +1,23 @@
> +#
> +# Test detecting ATRAC-3 audio in Sony MPEG files
> +#
> +
> +PROBE_CODEC_NAME_COMMAND = \
> +	ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream=codec_name \
> +	-select_streams a -print_format default=noprint_wrappers=1 -bitexact -v 0
> +
> +FATE_PSMF_FFPROBE = fate-psmf-probe-00006 \
> +					fate-psmf-probe-EV01_01_0500D
> +
> +fate-psmf-probe-00006: SRC = $(TARGET_SAMPLES)/psmf/00006.MPS
> +fate-psmf-probe-00006: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
> +fate-psmf-probe-00006: CMP = oneline
> +fate-psmf-probe-00006: REF = codec_name=atrac3p
> +fate-psmf-probe-EV01_01_0500D: SRC = $(TARGET_SAMPLES)/psmf/EV01_01_0500D.PMF
> +fate-psmf-probe-EV01_01_0500D: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
> +fate-psmf-probe-EV01_01_0500D: CMP = oneline
> +fate-psmf-probe-EV01_01_0500D: REF = codec_name=atrac3p

where are the sample files ?
did i miss a upload request ?

[...]
Rostislav Pehlivanov Dec. 25, 2017, 11:32 p.m. UTC | #2
On 25 December 2017 at 23:27, Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Mon, Dec 25, 2017 at 10:28:34AM +0800, misty@brew.sh wrote:
> > From: Misty De Meo <mistydemeo@gmail.com>
> >
> > ---
> >  tests/Makefile      |  1 +
> >  tests/fate/psmf.mak | 23 +++++++++++++++++++++++
> >  2 files changed, 24 insertions(+)
> >  create mode 100644 tests/fate/psmf.mak
> >
> > diff --git a/tests/Makefile b/tests/Makefile
> > index fd3713fe81..c569091fcb 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -165,6 +165,7 @@ include $(SRC_PATH)/tests/fate/pcm.mak
> >  include $(SRC_PATH)/tests/fate/pixlet.mak
> >  include $(SRC_PATH)/tests/fate/probe.mak
> >  include $(SRC_PATH)/tests/fate/prores.mak
> > +include $(SRC_PATH)/tests/fate/psmf.mak
> >  include $(SRC_PATH)/tests/fate/qt.mak
> >  include $(SRC_PATH)/tests/fate/qtrle.mak
> >  include $(SRC_PATH)/tests/fate/real.mak
> > diff --git a/tests/fate/psmf.mak b/tests/fate/psmf.mak
> > new file mode 100644
> > index 0000000000..0d83daad49
> > --- /dev/null
> > +++ b/tests/fate/psmf.mak
> > @@ -0,0 +1,23 @@
> > +#
> > +# Test detecting ATRAC-3 audio in Sony MPEG files
> > +#
> > +
> > +PROBE_CODEC_NAME_COMMAND = \
> > +     ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream=codec_name \
> > +     -select_streams a -print_format default=noprint_wrappers=1
> -bitexact -v 0
> > +
> > +FATE_PSMF_FFPROBE = fate-psmf-probe-00006 \
> > +                                     fate-psmf-probe-EV01_01_0500D
> > +
> > +fate-psmf-probe-00006: SRC = $(TARGET_SAMPLES)/psmf/00006.MPS
> > +fate-psmf-probe-00006: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
> > +fate-psmf-probe-00006: CMP = oneline
> > +fate-psmf-probe-00006: REF = codec_name=atrac3p
> > +fate-psmf-probe-EV01_01_0500D: SRC = $(TARGET_SAMPLES)/psmf/EV01_
> 01_0500D.PMF
> > +fate-psmf-probe-EV01_01_0500D: CMD = run $(PROBE_CODEC_NAME_COMMAND)
> -i "$(SRC)"
> > +fate-psmf-probe-EV01_01_0500D: CMP = oneline
> > +fate-psmf-probe-EV01_01_0500D: REF = codec_name=atrac3p
>
> where are the sample files ?
> did i miss a upload request ?
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I have never wished to cater to the crowd; for what I know they do not
> approve, and what they approve I do not know. -- Epicurus
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
They're in another email:
http://ffmpeg.org/pipermail/ffmpeg-devel/2017-December/222885.html
Michael Niedermayer Dec. 26, 2017, 12:31 p.m. UTC | #3
On Mon, Dec 25, 2017 at 11:32:50PM +0000, Rostislav Pehlivanov wrote:
> On 25 December 2017 at 23:27, Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
> > On Mon, Dec 25, 2017 at 10:28:34AM +0800, misty@brew.sh wrote:
> > > From: Misty De Meo <mistydemeo@gmail.com>
> > >
> > > ---
> > >  tests/Makefile      |  1 +
> > >  tests/fate/psmf.mak | 23 +++++++++++++++++++++++
> > >  2 files changed, 24 insertions(+)
> > >  create mode 100644 tests/fate/psmf.mak
> > >
> > > diff --git a/tests/Makefile b/tests/Makefile
> > > index fd3713fe81..c569091fcb 100644
> > > --- a/tests/Makefile
> > > +++ b/tests/Makefile
> > > @@ -165,6 +165,7 @@ include $(SRC_PATH)/tests/fate/pcm.mak
> > >  include $(SRC_PATH)/tests/fate/pixlet.mak
> > >  include $(SRC_PATH)/tests/fate/probe.mak
> > >  include $(SRC_PATH)/tests/fate/prores.mak
> > > +include $(SRC_PATH)/tests/fate/psmf.mak
> > >  include $(SRC_PATH)/tests/fate/qt.mak
> > >  include $(SRC_PATH)/tests/fate/qtrle.mak
> > >  include $(SRC_PATH)/tests/fate/real.mak
> > > diff --git a/tests/fate/psmf.mak b/tests/fate/psmf.mak
> > > new file mode 100644
> > > index 0000000000..0d83daad49
> > > --- /dev/null
> > > +++ b/tests/fate/psmf.mak
> > > @@ -0,0 +1,23 @@
> > > +#
> > > +# Test detecting ATRAC-3 audio in Sony MPEG files
> > > +#
> > > +
> > > +PROBE_CODEC_NAME_COMMAND = \
> > > +     ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream=codec_name \
> > > +     -select_streams a -print_format default=noprint_wrappers=1
> > -bitexact -v 0
> > > +
> > > +FATE_PSMF_FFPROBE = fate-psmf-probe-00006 \
> > > +                                     fate-psmf-probe-EV01_01_0500D
> > > +
> > > +fate-psmf-probe-00006: SRC = $(TARGET_SAMPLES)/psmf/00006.MPS
> > > +fate-psmf-probe-00006: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
> > > +fate-psmf-probe-00006: CMP = oneline
> > > +fate-psmf-probe-00006: REF = codec_name=atrac3p
> > > +fate-psmf-probe-EV01_01_0500D: SRC = $(TARGET_SAMPLES)/psmf/EV01_
> > 01_0500D.PMF
> > > +fate-psmf-probe-EV01_01_0500D: CMD = run $(PROBE_CODEC_NAME_COMMAND)
> > -i "$(SRC)"
> > > +fate-psmf-probe-EV01_01_0500D: CMP = oneline
> > > +fate-psmf-probe-EV01_01_0500D: REF = codec_name=atrac3p
> >
> > where are the sample files ?
> > did i miss a upload request ?
> >
> > [...]
> > --
> > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > I have never wished to cater to the crowd; for what I know they do not
> > approve, and what they approve I do not know. -- Epicurus
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> >
> They're in another email:
> http://ffmpeg.org/pipermail/ffmpeg-devel/2017-December/222885.html

Missed these
one is 512k one 1.7m, these seem a bit large for just testing filetype probing
is this intended ?


[...]
diff mbox

Patch

diff --git a/tests/Makefile b/tests/Makefile
index fd3713fe81..c569091fcb 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -165,6 +165,7 @@  include $(SRC_PATH)/tests/fate/pcm.mak
 include $(SRC_PATH)/tests/fate/pixlet.mak
 include $(SRC_PATH)/tests/fate/probe.mak
 include $(SRC_PATH)/tests/fate/prores.mak
+include $(SRC_PATH)/tests/fate/psmf.mak
 include $(SRC_PATH)/tests/fate/qt.mak
 include $(SRC_PATH)/tests/fate/qtrle.mak
 include $(SRC_PATH)/tests/fate/real.mak
diff --git a/tests/fate/psmf.mak b/tests/fate/psmf.mak
new file mode 100644
index 0000000000..0d83daad49
--- /dev/null
+++ b/tests/fate/psmf.mak
@@ -0,0 +1,23 @@ 
+#
+# Test detecting ATRAC-3 audio in Sony MPEG files
+#
+
+PROBE_CODEC_NAME_COMMAND = \
+	ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream=codec_name \
+	-select_streams a -print_format default=noprint_wrappers=1 -bitexact -v 0
+
+FATE_PSMF_FFPROBE = fate-psmf-probe-00006 \
+					fate-psmf-probe-EV01_01_0500D
+
+fate-psmf-probe-00006: SRC = $(TARGET_SAMPLES)/psmf/00006.MPS
+fate-psmf-probe-00006: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
+fate-psmf-probe-00006: CMP = oneline
+fate-psmf-probe-00006: REF = codec_name=atrac3p
+fate-psmf-probe-EV01_01_0500D: SRC = $(TARGET_SAMPLES)/psmf/EV01_01_0500D.PMF
+fate-psmf-probe-EV01_01_0500D: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)"
+fate-psmf-probe-EV01_01_0500D: CMP = oneline
+fate-psmf-probe-EV01_01_0500D: REF = codec_name=atrac3p
+
+FATE_SAMPLES_FFPROBE += $(FATE_PSMF_FFPROBE)
+
+fate-psmf: $(FATE_PSMF_FFPROBE)