diff mbox

[FFmpeg-devel,1/2] avfilter/vf_transpose: Fix regression with packed pixel formats

Message ID 20180128124551.22006-1-michael@niedermayer.cc
State Accepted
Commit 3f621455d62e46745453568d915badd5b1e5bcd5
Headers show

Commit Message

Michael Niedermayer Jan. 28, 2018, 12:45 p.m. UTC 
Regression since: c6939f65a116b1ffed345d29d8621ee4ffb32235
Found-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavfilter/vf_transpose.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol Jan. 28, 2018, 12:55 p.m. UTC | #1 
On 1/28/18, Michael Niedermayer <michael@niedermayer.cc> wrote:
> Regression since: c6939f65a116b1ffed345d29d8621ee4ffb32235
> Found-by: Paul B Mahol <onemda@gmail.com>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavfilter/vf_transpose.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_transpose.c b/libavfilter/vf_transpose.c
> index 1e1a5c4b89..3ff4cb4249 100644
> --- a/libavfilter/vf_transpose.c
> +++ b/libavfilter/vf_transpose.c
> @@ -217,7 +217,7 @@ static int config_props_output(AVFilterLink *outlink)
>
>      s->hsub = desc_in->log2_chroma_w;
>      s->vsub = desc_in->log2_chroma_h;
> -    s->planes = desc_in->nb_components;
> +    s->planes = av_pix_fmt_count_planes(outlink->format);
>
>      av_assert0(desc_in->nb_components == desc_out->nb_components);

lgtm
Michael Niedermayer Jan. 28, 2018, 1:47 p.m. UTC | #2 
On Sun, Jan 28, 2018 at 01:55:01PM +0100, Paul B Mahol wrote:
> On 1/28/18, Michael Niedermayer <michael@niedermayer.cc> wrote:
> > Regression since: c6939f65a116b1ffed345d29d8621ee4ffb32235
> > Found-by: Paul B Mahol <onemda@gmail.com>
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavfilter/vf_transpose.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavfilter/vf_transpose.c b/libavfilter/vf_transpose.c
> > index 1e1a5c4b89..3ff4cb4249 100644
> > --- a/libavfilter/vf_transpose.c
> > +++ b/libavfilter/vf_transpose.c
> > @@ -217,7 +217,7 @@ static int config_props_output(AVFilterLink *outlink)
> >
> >      s->hsub = desc_in->log2_chroma_w;
> >      s->vsub = desc_in->log2_chroma_h;
> > -    s->planes = desc_in->nb_components;
> > +    s->planes = av_pix_fmt_count_planes(outlink->format);
> >
> >      av_assert0(desc_in->nb_components == desc_out->nb_components);
> 
> lgtm

will apply

thanks

[...]
diff mbox

Patch

diff --git a/libavfilter/vf_transpose.c b/libavfilter/vf_transpose.c
index 1e1a5c4b89..3ff4cb4249 100644
--- a/libavfilter/vf_transpose.c
+++ b/libavfilter/vf_transpose.c
@@ -217,7 +217,7 @@  static int config_props_output(AVFilterLink *outlink)
 
     s->hsub = desc_in->log2_chroma_w;
     s->vsub = desc_in->log2_chroma_h;
-    s->planes = desc_in->nb_components;
+    s->planes = av_pix_fmt_count_planes(outlink->format);
 
     av_assert0(desc_in->nb_components == desc_out->nb_components);