| Message ID | 20180205110624.1971-1-atomnuker@gmail.com |
|---|---|
| State | Accepted |
| Commit | 33d632d40e147f99aaacafd9621f696a27dbf239 |
| Headers | show |
Rostislav Pehlivanov (2018-02-05): > Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com> > --- > libavfilter/opencl/.gitignore | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 libavfilter/opencl/.gitignore Do we have a maintainer for the opencl subdirectory? Regards,
On 5 February 2018 at 15:23, Nicolas George <george@nsup.org> wrote: > Rostislav Pehlivanov (2018-02-05): > > Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com> > > --- > > libavfilter/opencl/.gitignore | 1 + > > 1 file changed, 1 insertion(+) > > create mode 100644 libavfilter/opencl/.gitignore > > Do we have a maintainer for the opencl subdirectory? > > Regards, > > -- > Nicolas George > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > Mark Thompson since he wrote support for OpenCL
On 05/02/18 11:06, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com> > --- > libavfilter/opencl/.gitignore | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 libavfilter/opencl/.gitignore > > diff --git a/libavfilter/opencl/.gitignore b/libavfilter/opencl/.gitignore > new file mode 100644 > index 0000000000..064a8d8ef5 > --- /dev/null > +++ b/libavfilter/opencl/.gitignore > @@ -0,0 +1 @@ > +*.c > How did you end up with .c files here? The generated files should only be in the build directory. - Mark
On 07/02/18 10:46, Mark Thompson wrote: > On 05/02/18 11:06, Rostislav Pehlivanov wrote: >> Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com> >> --- >> libavfilter/opencl/.gitignore | 1 + >> 1 file changed, 1 insertion(+) >> create mode 100644 libavfilter/opencl/.gitignore >> >> diff --git a/libavfilter/opencl/.gitignore b/libavfilter/opencl/.gitignore >> new file mode 100644 >> index 0000000000..064a8d8ef5 >> --- /dev/null >> +++ b/libavfilter/opencl/.gitignore >> @@ -0,0 +1 @@ >> +*.c >> > > How did you end up with .c files here? The generated files should only be in the build directory. Sorry, in-tree builds are possible. Patch LGTM. - Mark
On 7 February 2018 at 11:09, Mark Thompson <sw@jkqxz.net> wrote: > On 07/02/18 10:46, Mark Thompson wrote: > > On 05/02/18 11:06, Rostislav Pehlivanov wrote: > >> Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com> > >> --- > >> libavfilter/opencl/.gitignore | 1 + > >> 1 file changed, 1 insertion(+) > >> create mode 100644 libavfilter/opencl/.gitignore > >> > >> diff --git a/libavfilter/opencl/.gitignore b/libavfilter/opencl/. > gitignore > >> new file mode 100644 > >> index 0000000000..064a8d8ef5 > >> --- /dev/null > >> +++ b/libavfilter/opencl/.gitignore > >> @@ -0,0 +1 @@ > >> +*.c > >> > > > > How did you end up with .c files here? The generated files should only > be in the build directory. > > Sorry, in-tree builds are possible. > > Patch LGTM. > > - Mark > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > Thanks, pushed
diff --git a/libavfilter/opencl/.gitignore b/libavfilter/opencl/.gitignore new file mode 100644 index 0000000000..064a8d8ef5 --- /dev/null +++ b/libavfilter/opencl/.gitignore @@ -0,0 +1 @@ +*.c
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com> --- libavfilter/opencl/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 libavfilter/opencl/.gitignore