diff mbox

[FFmpeg-devel] avcodec: Document that init_static_data() is not intended for time consuming operations.

Message ID 20180206002108.15691-1-michael@niedermayer.cc
State Accepted
Commit ddd851f7cbcb9181445b81bb3ff526f11f69c295
Headers show

Commit Message

Michael Niedermayer Feb. 6, 2018, 12:21 a.m. UTC 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/avcodec.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Muhammad Faiz Feb. 6, 2018, 6:22 p.m. UTC | #1 
On Tue, Feb 6, 2018 at 7:21 AM, Michael Niedermayer
<michael@niedermayer.cc> wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/avcodec.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 8fbbc798a2..9f4e8dd3c5 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -3439,6 +3439,9 @@ typedef struct AVCodec {
>
>      /**
>       * Initialize codec static data, called from avcodec_register().
> +     *
> +     * This is not intended for time consuming operations as it is
> +     * run for every codec regardless of that codec being used.
>       */
>      void (*init_static_data)(struct AVCodec *codec);
>

LGTM.

Thank's.
Michael Niedermayer Feb. 6, 2018, 10:47 p.m. UTC | #2 
On Wed, Feb 07, 2018 at 01:22:30AM +0700, Muhammad Faiz wrote:
> On Tue, Feb 6, 2018 at 7:21 AM, Michael Niedermayer
> <michael@niedermayer.cc> wrote:
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavcodec/avcodec.h | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index 8fbbc798a2..9f4e8dd3c5 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -3439,6 +3439,9 @@ typedef struct AVCodec {
> >
> >      /**
> >       * Initialize codec static data, called from avcodec_register().
> > +     *
> > +     * This is not intended for time consuming operations as it is
> > +     * run for every codec regardless of that codec being used.
> >       */
> >      void (*init_static_data)(struct AVCodec *codec);
> >
> 
> LGTM.

will apply

thx

[...]
diff mbox

Patch

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 8fbbc798a2..9f4e8dd3c5 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -3439,6 +3439,9 @@  typedef struct AVCodec {
 
     /**
      * Initialize codec static data, called from avcodec_register().
+     *
+     * This is not intended for time consuming operations as it is
+     * run for every codec regardless of that codec being used.
      */
     void (*init_static_data)(struct AVCodec *codec);