diff mbox

[FFmpeg-devel] avformat/movenc: move the concatenated eac3 packet reference

Message ID 20180314023518.5960-1-jamrial@gmail.com
State Accepted
Commit 935a9986fc2ef4ab4a752632be258811ec7f695f
Headers show

Commit Message

James Almer March 14, 2018, 2:35 a.m. UTC 
Simplifies code.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/movenc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Michael Niedermayer March 15, 2018, 11:36 p.m. UTC | #1 
On Tue, Mar 13, 2018 at 11:35:18PM -0300, James Almer wrote:
> Simplifies code.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavformat/movenc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

should be ok

thx

[...]
James Almer March 15, 2018, 11:39 p.m. UTC | #2 
On 3/15/2018 8:36 PM, Michael Niedermayer wrote:
> On Tue, Mar 13, 2018 at 11:35:18PM -0300, James Almer wrote:
>> Simplifies code.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>  libavformat/movenc.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> should be ok
> 
> thx

Pushed, thanks.
diff mbox

Patch

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index a17bb85900..df6163bae5 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -491,10 +491,7 @@  concatenate:
         if (info->num_blocks != 6)
             goto end;
         av_packet_unref(pkt);
-        ret = av_packet_ref(pkt, &info->pkt);
-        if (ret < 0)
-            goto end;
-        av_packet_unref(&info->pkt);
+        av_packet_move_ref(pkt, &info->pkt);
         info->num_blocks = 0;
     }
     ret = pkt->size;