diff mbox

[FFmpeg-devel] avcodec/wmalosslessdec: Fix null pointer dereference in decode_frame()

Message ID 20180325013238.3054-1-michael@niedermayer.cc
State Accepted
Commit ea15915b2dc5aaa80c91879fbd183475a7e66e54
Headers show

Commit Message

Michael Niedermayer March 25, 2018, 1:32 a.m. UTC
Fixes: 2018_03_23_poc.wav
Found-by: GwanYeong Kim <gy741.kim@gmail.com>

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/wmalosslessdec.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Michael Niedermayer March 29, 2018, 6:57 p.m. UTC | #1
On Sun, Mar 25, 2018 at 03:32:38AM +0200, Michael Niedermayer wrote:
> Fixes: 2018_03_23_poc.wav
> Found-by: GwanYeong Kim <gy741.kim@gmail.com>
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/wmalosslessdec.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

will apply

[...]
diff mbox

Patch

diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c
index 59e8929586..eb1db615ae 100644
--- a/libavcodec/wmalosslessdec.c
+++ b/libavcodec/wmalosslessdec.c
@@ -1256,7 +1256,9 @@  static int decode_packet(AVCodecContext *avctx, void *data, int *got_frame_ptr,
             (frame_size = show_bits(gb, s->log2_frame_size)) &&
             frame_size <= remaining_bits(s, gb)) {
             save_bits(s, gb, frame_size, 0);
-            s->packet_done = !decode_frame(s);
+
+            if (!s->packet_loss)
+                s->packet_done = !decode_frame(s);
         } else if (!s->len_prefix
                    && s->num_saved_bits > get_bits_count(&s->gb)) {
             /* when the frames do not have a length prefix, we don't know the