diff mbox

[FFmpeg-devel,3/4] avcodec/shorten: Fix undefined integer overflow

Message ID 20180702184511.12534-3-michael@niedermayer.cc
State Accepted
Commit 70832333bba3b915040f415548518e136b44280e
Headers show

Commit Message

Michael Niedermayer July 2, 2018, 6:45 p.m. UTC 
Fixes: signed integer overflow: 8454144 * 256 cannot be represented in type 'int'
Fixes: 8788/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SHORTEN_fuzzer-5728205041303552

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/shorten.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/libavcodec/shorten.c b/libavcodec/shorten.c
index 18a12d0b97..79656e7757 100644
--- a/libavcodec/shorten.c
+++ b/libavcodec/shorten.c
@@ -177,7 +177,7 @@  static void fix_bitshift(ShortenContext *s, int32_t *buffer)
             buffer[i] = 0;
     } else if (s->bitshift != 0) {
         for (i = 0; i < s->blocksize; i++)
-            buffer[i] *= 1 << s->bitshift;
+            buffer[i] *= 1U << s->bitshift;
     }
 }