diff mbox

[FFmpeg-devel] avutil/pixfmt: Document chroma plane size for odd resolutions

Message ID 20180718202339.23239-1-michael@niedermayer.cc
State Accepted
Commit be0b77e6e83b61c2da338201b5ddfae1c9acedc5
Headers show

Commit Message

Michael Niedermayer July 18, 2018, 8:23 p.m. UTC 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavutil/pixfmt.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Carl Eugen Hoyos July 18, 2018, 10:15 p.m. UTC | #1 
2018-07-18 22:23 GMT+02:00, Michael Niedermayer <michael@niedermayer.cc>:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavutil/pixfmt.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
> index aea008bbdc..2b3307845e 100644
> --- a/libavutil/pixfmt.h
> +++ b/libavutil/pixfmt.h
> @@ -42,6 +42,10 @@
>   * This is stored as BGRA on little-endian CPU architectures and ARGB on
>   * big-endian CPUs.
>   *
> + * @note
> + * If the resolution is not a multiple of the chroma subsampling factor
> + * then the chroma plane resolution must be rounded up.

Lgtm, thank you!

Carl Eugen
Michael Niedermayer July 20, 2018, 10:40 a.m. UTC | #2 
On Thu, Jul 19, 2018 at 12:15:02AM +0200, Carl Eugen Hoyos wrote:
> 2018-07-18 22:23 GMT+02:00, Michael Niedermayer <michael@niedermayer.cc>:
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavutil/pixfmt.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
> > index aea008bbdc..2b3307845e 100644
> > --- a/libavutil/pixfmt.h
> > +++ b/libavutil/pixfmt.h
> > @@ -42,6 +42,10 @@
> >   * This is stored as BGRA on little-endian CPU architectures and ARGB on
> >   * big-endian CPUs.
> >   *
> > + * @note
> > + * If the resolution is not a multiple of the chroma subsampling factor
> > + * then the chroma plane resolution must be rounded up.
> 
> Lgtm, thank you!

will apply

thanks

[...]
diff mbox

Patch

diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h
index aea008bbdc..2b3307845e 100644
--- a/libavutil/pixfmt.h
+++ b/libavutil/pixfmt.h
@@ -42,6 +42,10 @@ 
  * This is stored as BGRA on little-endian CPU architectures and ARGB on
  * big-endian CPUs.
  *
+ * @note
+ * If the resolution is not a multiple of the chroma subsampling factor
+ * then the chroma plane resolution must be rounded up.
+ *
  * @par
  * When the pixel format is palettized RGB32 (AV_PIX_FMT_PAL8), the palettized
  * image data is stored in AVFrame.data[0]. The palette is transported in