| Message ID | 20180724224939.2804-1-michael@niedermayer.cc |
|---|---|
| State | New |
| Headers | show |
On Wed, Jul 25, 2018 at 6:50 AM Michael Niedermayer <michael@niedermayer.cc> wrote: > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > doc/formats.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/formats.texi b/doc/formats.texi > index a97d61063a..738a4bb6e2 100644 > --- a/doc/formats.texi > +++ b/doc/formats.texi > @@ -220,6 +220,9 @@ ffprobe -dump_separator " > @item max_streams @var{integer} (@emph{input}) > Specifies the maximum number of streams. This can be used to reject files that > would require too many resources due to a large number of streams. > + > +@item skip_estimate_duration_from_pts @var{bool} (@emph{input}) > +skip duration calculation from pts. > @end table > > @c man end FORMAT OPTIONS > -- LGTM
On 25-07-2018 04:19 AM, Michael Niedermayer wrote: > + > +@item skip_estimate_duration_from_pts @var{bool} (@emph{input}) > +skip duration calculation from pts. The function this is in is only called for MPEG-PS or seekable MPEG-TS. We should note that. The comment above the function says it's only used for MPEG-PS. Maybe update that too. Wouldn't it be better to move this as a private option for those two demuxers? Gyan
On Wed, Jul 25, 2018 at 10:13:58AM +0530, Gyan Doshi wrote: > > > On 25-07-2018 04:19 AM, Michael Niedermayer wrote: > > >+ > >+@item skip_estimate_duration_from_pts @var{bool} (@emph{input}) > >+skip duration calculation from pts. > > The function this is in is only called for MPEG-PS or seekable MPEG-TS. > We should note that. > > The comment above the function says it's only used for MPEG-PS. Maybe update > that too. > > Wouldn't it be better to move this as a private option for those two > demuxers? iam not sure, it could be used by others in the future too what do people prefer ? I have no real oppinion on where to put it as long as it is documented somewhere in the docs ... thx [...]
On 26-07-2018 03:37 AM, Michael Niedermayer wrote: > On Wed, Jul 25, 2018 at 10:13:58AM +0530, Gyan Doshi wrote: >> Wouldn't it be better to move this as a private option for those two >> demuxers? > > iam not sure, it could be used by others in the future too > what do people prefer ? I have no real oppinion on where to put it as long > as it is documented somewhere in the docs ... Looking at the history, this function was added for MPEG-PS in 2003, and then used for TS in 2006. Hasn't been used for any other demuxers. You then added a similar function for NUT but within the demuxer. We can leave the possible shifting for later on, but let's add the limitation to the doc. Thanks, Gyan
On 26-07-2018 11:38 AM, Gyan Doshi wrote: > > On 26-07-2018 03:37 AM, Michael Niedermayer wrote: >> what do people prefer ? I have no real oppinion on where to put it as >> long >> as it is documented somewhere in the docs ... > ... > > We can leave the possible shifting for later on, but let's add the > limitation to the doc. I'll modify and push this tomorrow. Gyan
On Sun, Jul 29, 2018 at 10:57:58PM +0530, Gyan Doshi wrote: > > > On 26-07-2018 11:38 AM, Gyan Doshi wrote: > > > >On 26-07-2018 03:37 AM, Michael Niedermayer wrote: > > >>what do people prefer ? I have no real oppinion on where to put it as > >>long > >>as it is documented somewhere in the docs ... > > > ... > > > >We can leave the possible shifting for later on, but let's add the > >limitation to the doc. > > I'll modify and push this tomorrow. sure, thx [...]
On 30-07-2018 04:37 AM, Michael Niedermayer wrote: >> >> I'll modify and push this tomorrow. > > sure, thx Pushed as 67fb9c75efec9f069fc57b3ed211a35c63c686e5 Thanks, Gyan
diff --git a/doc/formats.texi b/doc/formats.texi index a97d61063a..738a4bb6e2 100644 --- a/doc/formats.texi +++ b/doc/formats.texi @@ -220,6 +220,9 @@ ffprobe -dump_separator " @item max_streams @var{integer} (@emph{input}) Specifies the maximum number of streams. This can be used to reject files that would require too many resources due to a large number of streams. + +@item skip_estimate_duration_from_pts @var{bool} (@emph{input}) +skip duration calculation from pts. @end table @c man end FORMAT OPTIONS
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- doc/formats.texi | 3 +++ 1 file changed, 3 insertions(+)