diff mbox

[FFmpeg-devel] avformat/flvenc: Check audio packet size

Message ID 20180728131609.16663-1-michael@niedermayer.cc
State Accepted
Commit 6b67d7f05918f7a1ee8fc6ff21355d7e8736aa10
Headers show

Commit Message

Michael Niedermayer July 28, 2018, 1:16 p.m. UTC 
Fixes: Assertion failure
Fixes: assert_flvenc.c:941_1.swf

Found-by: #CHEN HONGXU# <HCHEN017@e.ntu.edu.sg>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/flvenc.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Michael Niedermayer Aug. 4, 2018, 2:17 p.m. UTC | #1 
On Sat, Jul 28, 2018 at 03:16:09PM +0200, Michael Niedermayer wrote:
> Fixes: Assertion failure
> Fixes: assert_flvenc.c:941_1.swf
> 
> Found-by: #CHEN HONGXU# <HCHEN017@e.ntu.edu.sg>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/flvenc.c | 5 +++++
>  1 file changed, 5 insertions(+)

will apply

[...]
diff mbox

Patch

diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
index 1c552a3e6b..e4863f1fc7 100644
--- a/libavformat/flvenc.c
+++ b/libavformat/flvenc.c
@@ -883,6 +883,11 @@  static int flv_write_packet(AVFormatContext *s, AVPacket *pkt)
     int flags = -1, flags_size, ret;
     int64_t cur_offset = avio_tell(pb);
 
+    if (par->codec_type == AVMEDIA_TYPE_AUDIO && !pkt->size) {
+        av_log(s, AV_LOG_WARNING, "Empty audio Packet\n");
+        return AVERROR(EINVAL);
+    }
+
     if (par->codec_id == AV_CODEC_ID_VP6F || par->codec_id == AV_CODEC_ID_VP6A ||
         par->codec_id == AV_CODEC_ID_VP6  || par->codec_id == AV_CODEC_ID_AAC)
         flags_size = 2;