diff mbox

[FFmpeg-devel,7/7] libavfilter: Adds proper file descriptions to dnn_srcnn.h and dnn_espcn.h.

Message ID 20180802185248.18168-8-dualfal@gmail.com
State Accepted
Commit 1f18a633c601da16d8c92e59be8bb20f39264031
Headers show

Commit Message

Sergey Lavrushkin Aug. 2, 2018, 6:52 p.m. UTC 
---
 libavfilter/dnn_espcn.h | 3 ++-
 libavfilter/dnn_srcnn.h | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Rostislav Pehlivanov Aug. 14, 2018, 6:46 p.m. UTC | #1 
On Thu, 2 Aug 2018 at 19:54, Sergey Lavrushkin <dualfal@gmail.com> wrote:

> ---
>  libavfilter/dnn_espcn.h | 3 ++-
>  libavfilter/dnn_srcnn.h | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/dnn_espcn.h b/libavfilter/dnn_espcn.h
> index 9344aa90fe..e0013fe1dd 100644
> --- a/libavfilter/dnn_espcn.h
> +++ b/libavfilter/dnn_espcn.h
> @@ -20,7 +20,8 @@
>
>  /**
>   * @file
> - * Default cnn weights for x2 upscaling with espcn model.
> + * This file contains CNN weights for ESPCN model (
> https://arxiv.org/abs/1609.05158),
> + * auto generated by scripts provided in the repository:
> https://github.com/HighVoltageRocknRoll/sr.git.
>   */
>
>  #ifndef AVFILTER_DNN_ESPCN_H
> diff --git a/libavfilter/dnn_srcnn.h b/libavfilter/dnn_srcnn.h
> index 4f5332ce18..8bf563bd62 100644
> --- a/libavfilter/dnn_srcnn.h
> +++ b/libavfilter/dnn_srcnn.h
> @@ -20,7 +20,8 @@
>
>  /**
>   * @file
> - * Default cnn weights for x2 upscaling with srcnn model.
> + * This file contains CNN weights for SRCNN model (
> https://arxiv.org/abs/1501.00092),
> + * auto generated by scripts provided in the repository:
> https://github.com/HighVoltageRocknRoll/sr.git.
>   */
>
>  #ifndef AVFILTER_DNN_SRCNN_H
> --
> 2.14.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Soo, when are you going to remove *all* the models from lavfi?
All need to be removed before we make a release.
Pedro Arthur Aug. 14, 2018, 7 p.m. UTC | #2 
I asked the student to prepare a patch, before he was working on
fixing the issues pointed in the previous patches.

2018-08-14 15:46 GMT-03:00 Rostislav Pehlivanov <atomnuker@gmail.com>:
> On Thu, 2 Aug 2018 at 19:54, Sergey Lavrushkin <dualfal@gmail.com> wrote:
>
>> ---
>>  libavfilter/dnn_espcn.h | 3 ++-
>>  libavfilter/dnn_srcnn.h | 3 ++-
>>  2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavfilter/dnn_espcn.h b/libavfilter/dnn_espcn.h
>> index 9344aa90fe..e0013fe1dd 100644
>> --- a/libavfilter/dnn_espcn.h
>> +++ b/libavfilter/dnn_espcn.h
>> @@ -20,7 +20,8 @@
>>
>>  /**
>>   * @file
>> - * Default cnn weights for x2 upscaling with espcn model.
>> + * This file contains CNN weights for ESPCN model (
>> https://arxiv.org/abs/1609.05158),
>> + * auto generated by scripts provided in the repository:
>> https://github.com/HighVoltageRocknRoll/sr.git.
>>   */
>>
>>  #ifndef AVFILTER_DNN_ESPCN_H
>> diff --git a/libavfilter/dnn_srcnn.h b/libavfilter/dnn_srcnn.h
>> index 4f5332ce18..8bf563bd62 100644
>> --- a/libavfilter/dnn_srcnn.h
>> +++ b/libavfilter/dnn_srcnn.h
>> @@ -20,7 +20,8 @@
>>
>>  /**
>>   * @file
>> - * Default cnn weights for x2 upscaling with srcnn model.
>> + * This file contains CNN weights for SRCNN model (
>> https://arxiv.org/abs/1501.00092),
>> + * auto generated by scripts provided in the repository:
>> https://github.com/HighVoltageRocknRoll/sr.git.
>>   */
>>
>>  #ifndef AVFILTER_DNN_SRCNN_H
>> --
>> 2.14.1
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>
> Soo, when are you going to remove *all* the models from lavfi?
> All need to be removed before we make a release.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
diff mbox

Patch

diff --git a/libavfilter/dnn_espcn.h b/libavfilter/dnn_espcn.h
index 9344aa90fe..e0013fe1dd 100644
--- a/libavfilter/dnn_espcn.h
+++ b/libavfilter/dnn_espcn.h
@@ -20,7 +20,8 @@ 
 
 /**
  * @file
- * Default cnn weights for x2 upscaling with espcn model.
+ * This file contains CNN weights for ESPCN model (https://arxiv.org/abs/1609.05158),
+ * auto generated by scripts provided in the repository: https://github.com/HighVoltageRocknRoll/sr.git.
  */
 
 #ifndef AVFILTER_DNN_ESPCN_H
diff --git a/libavfilter/dnn_srcnn.h b/libavfilter/dnn_srcnn.h
index 4f5332ce18..8bf563bd62 100644
--- a/libavfilter/dnn_srcnn.h
+++ b/libavfilter/dnn_srcnn.h
@@ -20,7 +20,8 @@ 
 
 /**
  * @file
- * Default cnn weights for x2 upscaling with srcnn model.
+ * This file contains CNN weights for SRCNN model (https://arxiv.org/abs/1501.00092),
+ * auto generated by scripts provided in the repository: https://github.com/HighVoltageRocknRoll/sr.git.
  */
 
 #ifndef AVFILTER_DNN_SRCNN_H