diff mbox

[FFmpeg-devel,2/3] avformat/mlvdec: read_string() received unsigned size, make the argument unsigned

Message ID 20180816133629.9352-2-michael@niedermayer.cc
State Accepted
Commit 1e71cb2c8edcf3dad657c15a6fb8572862f2afb9
Headers show

Commit Message

Michael Niedermayer Aug. 16, 2018, 1:36 p.m. UTC 
Fixes: infinite loop
Fixes: mlv-timeout-e3b8cab9835edecad6823baa057e029671329d04

Found-by: Paul Ch <paulcher@icloud.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/mlvdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol Aug. 16, 2018, 1:47 p.m. UTC | #1 
On 8/16/18, Michael Niedermayer <michael@niedermayer.cc> wrote:
> Fixes: infinite loop
> Fixes: mlv-timeout-e3b8cab9835edecad6823baa057e029671329d04
>
> Found-by: Paul Ch <paulcher@icloud.com>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/mlvdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM
Michael Niedermayer Aug. 17, 2018, 7:45 p.m. UTC | #2 
On Thu, Aug 16, 2018 at 03:47:55PM +0200, Paul B Mahol wrote:
> On 8/16/18, Michael Niedermayer <michael@niedermayer.cc> wrote:
> > Fixes: infinite loop
> > Fixes: mlv-timeout-e3b8cab9835edecad6823baa057e029671329d04
> >
> > Found-by: Paul Ch <paulcher@icloud.com>
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavformat/mlvdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> LGTM

will apply

thanks

[...]
diff mbox

Patch

diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c
index d387c871ee..ded8196af2 100644
--- a/libavformat/mlvdec.c
+++ b/libavformat/mlvdec.c
@@ -77,7 +77,7 @@  static int check_file_header(AVIOContext *pb, uint64_t guid)
     return 0;
 }
 
-static void read_string(AVFormatContext *avctx, AVIOContext *pb, const char *tag, int size)
+static void read_string(AVFormatContext *avctx, AVIOContext *pb, const char *tag, unsigned size)
 {
     char * value = av_malloc(size + 1);
     if (!value) {