diff mbox

[FFmpeg-devel] avutil/integer: Fix integer overflow in av_mul_i()

Message ID 20181024000136.13688-1-michael@niedermayer.cc
State Accepted
Commit 3cc3cb663bf3061e40356392d2f7638de6a479fe
Headers show

Commit Message

Michael Niedermayer Oct. 24, 2018, 12:01 a.m. UTC 
Found-by: fate
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavutil/integer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer Oct. 24, 2018, 9:15 p.m. UTC | #1 
On Wed, Oct 24, 2018 at 02:01:36AM +0200, Michael Niedermayer wrote:
> Found-by: fate
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavutil/integer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

will apply

[...]
diff mbox

Patch

diff --git a/libavutil/integer.c b/libavutil/integer.c
index 890e314dce..78e252fbde 100644
--- a/libavutil/integer.c
+++ b/libavutil/integer.c
@@ -74,7 +74,7 @@  AVInteger av_mul_i(AVInteger a, AVInteger b){
 
         if(a.v[i])
             for(j=i; j<AV_INTEGER_SIZE && j-i<=nb; j++){
-                carry= (carry>>16) + out.v[j] + a.v[i]*b.v[j-i];
+                carry= (carry>>16) + out.v[j] + a.v[i]*(unsigned)b.v[j-i];
                 out.v[j]= carry;
             }
     }