diff mbox

[FFmpeg-devel,1/2] avcodec/cbs_av1: fix storage size for segmentation_params feature_value fields

Message ID 20181111022414.10964-1-jamrial@gmail.com
State Accepted
Commit 79831f4531d98c3c1eab96c10f1135d08abef5f3
Headers show

Commit Message

James Almer Nov. 11, 2018, 2:24 a.m. UTC 
The valid range is -255 to 255.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/cbs_av1.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Thompson Nov. 14, 2018, 9:57 p.m. UTC | #1 
On 11/11/18 02:24, James Almer wrote:
> The valid range is -255 to 255.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/cbs_av1.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/cbs_av1.h b/libavcodec/cbs_av1.h
> index f662265f75..84622ed189 100644
> --- a/libavcodec/cbs_av1.h
> +++ b/libavcodec/cbs_av1.h
> @@ -210,7 +210,7 @@ typedef struct AV1RawFrameHeader {
>      uint8_t segmentation_temporal_update;
>      uint8_t segmentation_update_data;
>      uint8_t feature_enabled[AV1_MAX_SEGMENTS][AV1_SEG_LVL_MAX];
> -    uint8_t feature_value[AV1_MAX_SEGMENTS][AV1_SEG_LVL_MAX];
> +    int16_t feature_value[AV1_MAX_SEGMENTS][AV1_SEG_LVL_MAX];
>  
>      uint8_t delta_q_present;
>      uint8_t delta_q_res;
> 

Yep, LGTM.

Thanks,

- Mark
diff mbox

Patch

diff --git a/libavcodec/cbs_av1.h b/libavcodec/cbs_av1.h
index f662265f75..84622ed189 100644
--- a/libavcodec/cbs_av1.h
+++ b/libavcodec/cbs_av1.h
@@ -210,7 +210,7 @@  typedef struct AV1RawFrameHeader {
     uint8_t segmentation_temporal_update;
     uint8_t segmentation_update_data;
     uint8_t feature_enabled[AV1_MAX_SEGMENTS][AV1_SEG_LVL_MAX];
-    uint8_t feature_value[AV1_MAX_SEGMENTS][AV1_SEG_LVL_MAX];
+    int16_t feature_value[AV1_MAX_SEGMENTS][AV1_SEG_LVL_MAX];
 
     uint8_t delta_q_present;
     uint8_t delta_q_res;