[FFmpeg-devel] fate/proresenc_aw : Add fate test for interlace and 444 encoding

On Sat, Feb 23, 2019 at 07:10:06PM +0100, Martin Vignali wrote:
> Hello,
> 
> Patch in attach add fate test for interlace and 444 encoding
> 
> All prores_aw encoding test can be test with :
> 
> make fate-vsynth3-prores;make fate-vsynth2-prores;make
> fate-vsynth1-prores;make fate-vsynth_lena-prores SAMPLES=fate-suite/;make
> fate-vsynth3-prores_int;make fate-vsynth2-prores_int;make
> fate-vsynth1-prores_int;make fate-vsynth_lena-prores_int
> SAMPLES=fate-suite/;make fate-vsynth3-prores_444;make
> fate-vsynth2-prores_444;make fate-vsynth1-prores_444;make
> fate-vsynth_lena-prores_444 SAMPLES=fate-suite/;make
> fate-vsynth3-prores_444_int;make fate-vsynth2-prores_444_int;make
> fate-vsynth1-prores_444_int;make fate-vsynth_lena-prores_444_int
> SAMPLES=fate-suite/
> 
> Martin

it seems a make fate fails with this: (linux x86-64)

Test vsynth3-prores_444_int failed. Look at tests/data/fate/vsynth3-prores_444_int.err for details.
make: *** [fate-vsynth3-prores_444_int] Error 1

[...]

Hello,

Thanks for testing.
Can you send me the result file vsynth3-prores_int.mov, so i can try to
find why the result are not the same.

Only the two vsynth3 interlaced test fail ?

Martin

On Mon, Feb 25, 2019 at 09:01:16PM +0100, Martin Vignali wrote:
> Hello,
> 
> Thanks for testing.
> Can you send me the result file vsynth3-prores_int.mov, so i can try to
> find why the result are not the same.

https://ffmpeg.org/~michael/vsynth3-prores_int.mov
https://ffmpeg.org/~michael/vsynth3-prores_444_int.mov


> 
> Only the two vsynth3 interlaced test fail ?

yes

thx

[...]

Hello,

Thanks for the files

The problem appear for "unsafe" resolution (only vsynth3 have this).

Patchs in attach are supposed to fix this
001 : fix sub_image_with_fill for interlaced encoding
002 : new fate test, with update result for vsynth3 interlace test

Can be test with :
make fate-vsynth3-prores_int;make fate-vsynth3-prores_444_int

Martin

On Tue, Feb 26, 2019 at 12:04:58PM +0100, Martin Vignali wrote:
> Hello,
> 
> Thanks for the files
> 
> The problem appear for "unsafe" resolution (only vsynth3 have this).
> 
> Patchs in attach are supposed to fix this
> 001 : fix sub_image_with_fill for interlaced encoding
> 002 : new fate test, with update result for vsynth3 interlace test
> 
> Can be test with :
> make fate-vsynth3-prores_int;make fate-vsynth3-prores_444_int

works here

thx

[...]

> works here
>
>
 Pushed, thanks.

Martin

On Wed, Feb 27, 2019 at 6:05 PM Martin Vignali <martin.vignali@gmail.com> wrote:
>
> > works here
> >
> >
>  Pushed, thanks.
>

These tests fail on all FATE boxes. http://fate.ffmpeg.org/

Can you check that and fix it?

- Hendrik

>
> These tests fail on all FATE boxes. http://fate.ffmpeg.org/
>
> Can you check that and fix it?
>
>
Seems to be related to memory poisoning (pass when disable) :
http://fate.ffmpeg.org/report.cgi?time=20190307033138&slot=x86_64-archlinux-gcc-valgrind-no-undef

Will take a look.

Martin

>> Can you check that and fix it?
>>
>>
>
Patch in attach fix for me vsynth3 interlace prores test :
make fate-vsynth3-prores_int;make fate-vsynth3-prores_444_int

Pass fate test for me (os x X86_64) with and without
--enable-memory-poisoning

Martin

On Fri, Mar 08, 2019 at 12:11:47AM +0100, Martin Vignali wrote:
> >> Can you check that and fix it?
> >>
> >>
> >
> Patch in attach fix for me vsynth3 interlace prores test :
> make fate-vsynth3-prores_int;make fate-vsynth3-prores_444_int
> 
> Pass fate test for me (os x X86_64) with and without
> --enable-memory-poisoning

With this patch applied, the vsynth3 test no longer fails on my systems.
Please apply!

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

On Fri, Mar 08, 2019 at 12:11:47AM +0100, Martin Vignali wrote:
> >> Can you check that and fix it?
> >>
> >>
> >
> Patch in attach fix for me vsynth3 interlace prores test :
> make fate-vsynth3-prores_int;make fate-vsynth3-prores_444_int
> 
> Pass fate test for me (os x X86_64) with and without
> --enable-memory-poisoning
> 
> Martin

>  libavcodec/proresenc_anatoliy.c         |    4 ++--
>  tests/ref/vsynth/vsynth3-prores_444_int |    8 ++++----
>  tests/ref/vsynth/vsynth3-prores_int     |    8 ++++----
>  3 files changed, 10 insertions(+), 10 deletions(-)
> 4dc0e29e35f88ba605b048fb841dc3c6a760b892  0001-avcodec-proresenc_aw-fix-interlace-encoding-for-unsa.patch
> From 8203aa9eb65e616df0c7ad3926a83484bec930d5 Mon Sep 17 00:00:00 2001
> From: Martin Vignali <martin.vignali@gmail.com>
> Date: Fri, 8 Mar 2019 00:06:01 +0100
> Subject: [PATCH] avcodec/proresenc_aw : fix interlace encoding for unsafe
>  height

tested on x86-64 and qemu mips, works with memory poisoning

thx

[...]

Pushed, thanks for testing.

Martin