diff mbox

[FFmpeg-devel,PATCHv3] FATE: Add test for HEVC files that claim to have two first slices

Message ID 20190321153828.82949-1-derek.buitenhuis@gmail.com
State New
Headers show

Commit Message

Derek Buitenhuis March 21, 2019, 3:38 p.m. UTC
This makes sure we don't regress on 70c8c8a818f39bc262565ec29fae2baffb3e1660.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
Same sample link as v2.

Also of note: I'm only adding the -t arg because FATE doesn't seem to have
a good way to allow ffmpeg to return a non-zero error code, but also have
the test pass.
---
 tests/fate/hevc.mak                 |  3 +++
 tests/ref/fate/hevc-two-first-slice | 39 +++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+)
 create mode 100644 tests/ref/fate/hevc-two-first-slice

Comments

James Almer March 21, 2019, 4:19 p.m. UTC | #1
On 3/21/2019 12:38 PM, Derek Buitenhuis wrote:
> This makes sure we don't regress on 70c8c8a818f39bc262565ec29fae2baffb3e1660.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
> Same sample link as v2.

Tried to upload it, but i'm still having the same issues as last time.
Someone else will have to.

> 
> Also of note: I'm only adding the -t arg because FATE doesn't seem to have
> a good way to allow ffmpeg to return a non-zero error code, but also have
> the test pass.
> ---
>  tests/fate/hevc.mak                 |  3 +++
>  tests/ref/fate/hevc-two-first-slice | 39 +++++++++++++++++++++++++++++
>  2 files changed, 42 insertions(+)
>  create mode 100644 tests/ref/fate/hevc-two-first-slice
> 
> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> index db3ea19340..8f9ed6d925 100644
> --- a/tests/fate/hevc.mak
> +++ b/tests/fate/hevc.mak
> @@ -253,6 +253,9 @@ fate-hevc-extradata-reload: CMD = framemd5 -i $(TARGET_SAMPLES)/hevc/extradata-r
>  fate-hevc-monochrome-crop: CMD = probeframes -show_entries frame=width,height:stream=width,height $(TARGET_SAMPLES)/hevc/hevc-monochrome.hevc
>  FATE_HEVC_FFPROBE-$(call DEMDEC, HEVC, HEVC) += fate-hevc-monochrome-crop
>  
> +fate-hevc-two-first-slice: CMD = threads=2 framemd5 -i $(TARGET_SAMPLES)/hevc/two_first_slice.mp4 -sws_flags bitexact -t 00:02.00 -an
> +FATE_HEVC += fate-hevc-two-first-slice

FATE_HEVC-$(call DEMDEC, MOV, HEVC)
Derek Buitenhuis March 21, 2019, 4:23 p.m. UTC | #2
On 21/03/2019 16:19, James Almer wrote:
> FATE_HEVC-$(call DEMDEC, MOV, HEVC)

Changed locally.

- Derek
Michael Niedermayer March 21, 2019, 9:30 p.m. UTC | #3
On Thu, Mar 21, 2019 at 01:19:48PM -0300, James Almer wrote:
> On 3/21/2019 12:38 PM, Derek Buitenhuis wrote:
> > This makes sure we don't regress on 70c8c8a818f39bc262565ec29fae2baffb3e1660.
> > 
> > Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> > ---
> > Same sample link as v2.
> 
> Tried to upload it, but i'm still having the same issues as last time.
> Someone else will have to.

hmm, was that rsync specific ? if so you could login and wget the file

about this specific file, 
derek should have write access to samples as well

[...]
James Almer March 21, 2019, 9:55 p.m. UTC | #4
On 3/21/2019 6:30 PM, Michael Niedermayer wrote:
> On Thu, Mar 21, 2019 at 01:19:48PM -0300, James Almer wrote:
>> On 3/21/2019 12:38 PM, Derek Buitenhuis wrote:
>>> This makes sure we don't regress on 70c8c8a818f39bc262565ec29fae2baffb3e1660.
>>>
>>> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
>>> ---
>>> Same sample link as v2.
>>
>> Tried to upload it, but i'm still having the same issues as last time.
>> Someone else will have to.
> 
> hmm, was that rsync specific ? if so you could login and wget the file
> 
> about this specific file, 
> derek should have write access to samples as well

No, i tried to ssh to the main repo, a test dry run push, and it gave me
the same error as ssh rsync did a couple months ago.
This is within an Arch Linux VM, freshly rebuilt and all. I can ssh just
fine from my native Windows host, so I don't know if it's a
configuration issue, VMWare or what, but the remote server simply
doesn't like the connections i try to establish.
Guess i'll have to see if i can use msys2's rsync for this without
making a mess.
Derek Buitenhuis March 25, 2019, 3:33 p.m. UTC | #5
On 21/03/2019 21:30, Michael Niedermayer wrote:
> about this specific file, 
> derek should have write access to samples as well

I actually don't remember the specifics / servers / etc...

- Derek
diff mbox

Patch

diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
index db3ea19340..8f9ed6d925 100644
--- a/tests/fate/hevc.mak
+++ b/tests/fate/hevc.mak
@@ -253,6 +253,9 @@  fate-hevc-extradata-reload: CMD = framemd5 -i $(TARGET_SAMPLES)/hevc/extradata-r
 fate-hevc-monochrome-crop: CMD = probeframes -show_entries frame=width,height:stream=width,height $(TARGET_SAMPLES)/hevc/hevc-monochrome.hevc
 FATE_HEVC_FFPROBE-$(call DEMDEC, HEVC, HEVC) += fate-hevc-monochrome-crop
 
+fate-hevc-two-first-slice: CMD = threads=2 framemd5 -i $(TARGET_SAMPLES)/hevc/two_first_slice.mp4 -sws_flags bitexact -t 00:02.00 -an
+FATE_HEVC += fate-hevc-two-first-slice
+
 FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
 FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
 
diff --git a/tests/ref/fate/hevc-two-first-slice b/tests/ref/fate/hevc-two-first-slice
new file mode 100644
index 0000000000..586b8ef5c3
--- /dev/null
+++ b/tests/ref/fate/hevc-two-first-slice
@@ -0,0 +1,39 @@ 
+#format: frame checksums
+#version: 2
+#hash: MD5
+#tb 0: 1/15
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 1920x1080
+#sar 0: 0/1
+#stream#, dts,        pts, duration,     size, hash
+0,          0,          0,        1,  3110400, c88154281ada839d3f209b0eab012577
+0,          1,          1,        1,  3110400, a2623ba4639cf246b803c08e7233112f
+0,          2,          2,        1,  3110400, 9208fcdb16664e91ada77d15cc29ace9
+0,          3,          3,        1,  3110400, 62a5afb0c4d189b831c8cca033a396e0
+0,          4,          4,        1,  3110400, a8f208f1323e9c14181549d480055e3c
+0,          5,          5,        1,  3110400, 3a66c0ab75362a73eebb9ef668bee3da
+0,          6,          6,        1,  3110400, 8096734441fe76d8f7bba8384029b1be
+0,          7,          7,        1,  3110400, ee8db0610de85f015ec76a0c14475ab8
+0,          8,          8,        1,  3110400, f52df359246a4ac396dfc74f75285347
+0,          9,          9,        1,  3110400, 8fb6ddd74e4b71c7596e90d47e50d8f1
+0,         10,         10,        1,  3110400, 70542a3ac5df77437c3d8097d19315c2
+0,         11,         11,        1,  3110400, 20bdf9399f6752578c574248627c3a9f
+0,         12,         12,        1,  3110400, a8b564575af5d72a2cc6d566e99e0176
+0,         13,         13,        1,  3110400, 0d4ace74eb6b452ea9cb2cc72371794a
+0,         14,         14,        1,  3110400, d9736a1e47da6541306cbf8496d97635
+0,         15,         15,        1,  3110400, 49bc2b608000c7d545fa362418035277
+0,         16,         16,        1,  3110400, bd64e9d545c666f818ea1af791ac4201
+0,         17,         17,        1,  3110400, 75b86260724937fdeddf47e1f28530a1
+0,         18,         18,        1,  3110400, 7df76be996e2c652da048e690e45313f
+0,         19,         19,        1,  3110400, 057b9a27f76c9205fe7f378c7e4fe1b4
+0,         20,         20,        1,  3110400, 08241ea9c8d27bd14117ca07485a9892
+0,         21,         21,        1,  3110400, 7d5f4d4e043d6f3e794d1222046cb9cf
+0,         22,         22,        1,  3110400, dfb6916da415ff5323a1925cc329c8e2
+0,         23,         23,        1,  3110400, 574730243f89b4824a313ea1b690e31b
+0,         24,         24,        1,  3110400, 63054e31f52171dda84faa201523dc3b
+0,         25,         25,        1,  3110400, d8ba349a9a5a6f38527e47f5519fd335
+0,         26,         26,        1,  3110400, e653543eb8a8a49147676a91bafbdec8
+0,         27,         27,        1,  3110400, b3194aced03ff1bc4d65560792eeab98
+0,         28,         28,        1,  3110400, 6ba07b8fd8422b3c14976062f5468fab
+0,         29,         29,        1,  3110400, bf8359596ddfd9fdbc243fc2fee56669