| Message ID | 20190704134348.6071-1-matthieu.bouron@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On 7/4/2019 10:43 AM, Matthieu Bouron wrote: > --- > libavcodec/mediacodec_wrapper.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h > index f0de16d669..58e5dc7d39 100644 > --- a/libavcodec/mediacodec_wrapper.h > +++ b/libavcodec/mediacodec_wrapper.h > @@ -26,6 +26,8 @@ > #include <stdint.h> > #include <sys/types.h> > > +#include <libavcodec/avcodec.h> "avcodec.h" is enough. This is an internal header. > + > /** > * The following API around MediaCodec and MediaFormat is based on the > * NDK one provided by Google since Android 5.0. >
Matthieu Bouron (12019-07-04): > --- > libavcodec/mediacodec_wrapper.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h > index f0de16d669..58e5dc7d39 100644 > --- a/libavcodec/mediacodec_wrapper.h > +++ b/libavcodec/mediacodec_wrapper.h > @@ -26,6 +26,8 @@ > #include <stdint.h> > #include <sys/types.h> > > +#include <libavcodec/avcodec.h> AFAIK, this is not the correct way of including one of our own headers, especially from the same sub-library. Just "avcodec.h". > + > /** > * The following API around MediaCodec and MediaFormat is based on the > * NDK one provided by Google since Android 5.0. Regards,
diff --git a/libavcodec/mediacodec_wrapper.h b/libavcodec/mediacodec_wrapper.h index f0de16d669..58e5dc7d39 100644 --- a/libavcodec/mediacodec_wrapper.h +++ b/libavcodec/mediacodec_wrapper.h @@ -26,6 +26,8 @@ #include <stdint.h> #include <sys/types.h> +#include <libavcodec/avcodec.h> + /** * The following API around MediaCodec and MediaFormat is based on the * NDK one provided by Google since Android 5.0.