diff mbox

[FFmpeg-devel] FATE/dnn: fix stack buffer overflow

Message ID 20191001063649.16098-1-quinkblack@foxmail.com
State Accepted
Commit 7c145b64417fbe674f90785d2e5a5afea1a1b821
Headers show

Commit Message

Zhao Zhili Oct. 1, 2019, 6:36 a.m. UTC
From: Zhao Zhili <zhilizhao@tencent.com>

---
 tests/dnn/dnn-layer-pad-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guo, Yejun Oct. 4, 2019, 12:11 p.m. UTC | #1
> -----Original Message-----

> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of

> quinkblack@foxmail.com

> Sent: Tuesday, October 01, 2019 2:37 PM

> To: ffmpeg-devel@ffmpeg.org

> Cc: Zhao Zhili <zhilizhao@tencent.com>

> Subject: [FFmpeg-devel] [PATCH] FATE/dnn: fix stack buffer overflow

> 

> From: Zhao Zhili <zhilizhao@tencent.com>

> 

> ---

>  tests/dnn/dnn-layer-pad-test.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/tests/dnn/dnn-layer-pad-test.c b/tests/dnn/dnn-layer-pad-test.c

> index 1fb2be1590..ea8c824d1e 100644

> --- a/tests/dnn/dnn-layer-pad-test.c

> +++ b/tests/dnn/dnn-layer-pad-test.c

> @@ -203,7 +203,7 @@ static int test_with_mode_constant(void)

>      params.paddings[3][1] = 2;

> 

>      operands[0].data = input;

> -    operands[0].dims[0] = 3;

> +    operands[0].dims[0] = 1;


nice catch, LGTM, thanks.

>      operands[0].dims[1] = 2;

>      operands[0].dims[2] = 2;

>      operands[0].dims[3] = 3;

> --

> 2.17.1

> 

> 

> 

> _______________________________________________

> ffmpeg-devel mailing list

> ffmpeg-devel@ffmpeg.org

> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

> 

> To unsubscribe, visit link above, or email

> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Pedro Arthur Oct. 4, 2019, 1:07 p.m. UTC | #2
Em sex, 4 de out de 2019 às 09:11, Guo, Yejun <yejun.guo@intel.com>
escreveu:

>
>
> > -----Original Message-----
> > From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of
> > quinkblack@foxmail.com
> > Sent: Tuesday, October 01, 2019 2:37 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Zhao Zhili <zhilizhao@tencent.com>
> > Subject: [FFmpeg-devel] [PATCH] FATE/dnn: fix stack buffer overflow
> >
> > From: Zhao Zhili <zhilizhao@tencent.com>
> >
> > ---
> >  tests/dnn/dnn-layer-pad-test.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/dnn/dnn-layer-pad-test.c
> b/tests/dnn/dnn-layer-pad-test.c
> > index 1fb2be1590..ea8c824d1e 100644
> > --- a/tests/dnn/dnn-layer-pad-test.c
> > +++ b/tests/dnn/dnn-layer-pad-test.c
> > @@ -203,7 +203,7 @@ static int test_with_mode_constant(void)
> >      params.paddings[3][1] = 2;
> >
> >      operands[0].data = input;
> > -    operands[0].dims[0] = 3;
> > +    operands[0].dims[0] = 1;
>
> nice catch, LGTM, thanks.
>
Pushed.


> >      operands[0].dims[1] = 2;
> >      operands[0].dims[2] = 2;
> >      operands[0].dims[3] = 3;
> > --
> > 2.17.1
> >
> >
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/tests/dnn/dnn-layer-pad-test.c b/tests/dnn/dnn-layer-pad-test.c
index 1fb2be1590..ea8c824d1e 100644
--- a/tests/dnn/dnn-layer-pad-test.c
+++ b/tests/dnn/dnn-layer-pad-test.c
@@ -203,7 +203,7 @@  static int test_with_mode_constant(void)
     params.paddings[3][1] = 2;
 
     operands[0].data = input;
-    operands[0].dims[0] = 3;
+    operands[0].dims[0] = 1;
     operands[0].dims[1] = 2;
     operands[0].dims[2] = 2;
     operands[0].dims[3] = 3;