diff mbox

[FFmpeg-devel] avfilter: remove unused private field of AVFilterLink

Message ID 20191018063631.24162-1-quinkblack@foxmail.com
State New
Headers show

Commit Message

zhilizhao Oct. 18, 2019, 6:36 a.m. UTC
From: Zhao Zhili <zhilizhao@tencent.com>

---
 libavfilter/avfilter.h | 5 -----
 1 file changed, 5 deletions(-)

Comments

Moritz Barsnick Oct. 28, 2019, 1:09 p.m. UTC | #1
On Fri, Oct 18, 2019 at 14:36:31 +0800, quinkblack@foxmail.com wrote:
> diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
> index 3eaa8a4089..3c87f4864a 100644
> --- a/libavfilter/avfilter.h
> +++ b/libavfilter/avfilter.h
> @@ -572,11 +572,6 @@ struct AVFilterLink {
>       */
>      int channels;
>
> -    /**
> -     * Link processing flags.
> -     */
> -    unsigned flags;
> -

Since this is a public header, this is part of the API and cannot be
removed without a deprecation period.

Moritz
Moritz Barsnick Oct. 28, 2019, 1:15 p.m. UTC | #2
On Mon, Oct 28, 2019 at 14:09:53 +0100, Moritz Barsnick wrote:
> > -    unsigned flags;
>
> Since this is a public header, this is part of the API and cannot be
> removed without a deprecation period.

Sorry, I missed that it says "Applications must not normally access the
link structure directly."

Forget my comment, and sorry for the noise.

Moritz
zhilizhao Oct. 28, 2019, 3:30 p.m. UTC | #3
> On Oct 28, 2019, at 9:15 PM, Moritz Barsnick <barsnick@gmx.net> wrote:
> 
> On Mon, Oct 28, 2019 at 14:09:53 +0100, Moritz Barsnick wrote:
>>> -    unsigned flags;
>> 
>> Since this is a public header, this is part of the API and cannot be
>> removed without a deprecation period.
> 
> Sorry, I missed that it says "Applications must not normally access the
> link structure directly."

Actually, I take the following comments as reference, it dating back to 2012

    /*****************************************************************
     * All fields below this line are not part of the public API. They
     * may not be used outside of libavfilter and can be changed and
     * removed at will.
     * New public fields should be added right above.
     *****************************************************************
     */

> 
> Forget my comment, and sorry for the noise.
> 
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
index 3eaa8a4089..3c87f4864a 100644
--- a/libavfilter/avfilter.h
+++ b/libavfilter/avfilter.h
@@ -572,11 +572,6 @@  struct AVFilterLink {
      */
     int channels;
 
-    /**
-     * Link processing flags.
-     */
-    unsigned flags;
-
     /**
      * Number of past frames sent through the link.
      */