diff mbox

[FFmpeg-devel,v2,1/3] avfilter/vf_elbg: Fix for the seed type

Message ID 20191122015038.14784-1-lance.lmwang@gmail.com
State New
Headers show

Commit Message

Limin Wang Nov. 22, 2019, 1:50 a.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavfilter/vf_elbg.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Limin Wang Dec. 3, 2019, 2:21 p.m. UTC | #1
ping the patchset, thx.

On Fri, Nov 22, 2019 at 09:50:36AM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavfilter/vf_elbg.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libavfilter/vf_elbg.c b/libavfilter/vf_elbg.c
> index b59da9ec85..5bccb5f58d 100644
> --- a/libavfilter/vf_elbg.c
> +++ b/libavfilter/vf_elbg.c
> @@ -36,7 +36,7 @@
>  typedef struct ELBGContext {
>      const AVClass *class;
>      AVLFG lfg;
> -    unsigned int lfg_seed;
> +    int64_t lfg_seed;
>      int max_steps_nb;
>      int *codeword;
>      int codeword_length;
> @@ -56,8 +56,8 @@ static const AVOption elbg_options[] = {
>      { "l",               "set codebook length", OFFSET(codebook_length), AV_OPT_TYPE_INT, { .i64 = 256 }, 1, INT_MAX, FLAGS },
>      { "nb_steps", "set max number of steps used to compute the mapping", OFFSET(max_steps_nb), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS },
>      { "n",        "set max number of steps used to compute the mapping", OFFSET(max_steps_nb), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS },
> -    { "seed", "set the random seed", OFFSET(lfg_seed), AV_OPT_TYPE_INT, {.i64 = -1}, -1, UINT32_MAX, FLAGS },
> -    { "s",    "set the random seed", OFFSET(lfg_seed), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, UINT32_MAX, FLAGS },
> +    { "seed", "set the random seed", OFFSET(lfg_seed), AV_OPT_TYPE_INT64, {.i64 = -1}, -1, UINT32_MAX, FLAGS },
> +    { "s",    "set the random seed", OFFSET(lfg_seed), AV_OPT_TYPE_INT64, { .i64 = -1 }, -1, UINT32_MAX, FLAGS },
>      { "pal8", "set the pal8 output", OFFSET(pal8), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS },
>      { NULL }
>  };
> -- 
> 2.21.0
>
Michael Niedermayer Dec. 4, 2019, 7:31 p.m. UTC | #2
On Fri, Nov 22, 2019 at 09:50:36AM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavfilter/vf_elbg.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

will apply

thx

[...]
Limin Wang Dec. 5, 2019, 1:54 p.m. UTC | #3
On Wed, Dec 04, 2019 at 08:31:15PM +0100, Michael Niedermayer wrote:
> On Fri, Nov 22, 2019 at 09:50:36AM +0800, lance.lmwang@gmail.com wrote:
> > From: Limin Wang <lance.lmwang@gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  libavfilter/vf_elbg.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> will apply

Thanks, please help to review the PATCH v2 2/3 and 3/3 also, 
they're fix the same typo.

> 
> thx
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> I have never wished to cater to the crowd; for what I know they do not
> approve, and what they approve I do not know. -- Epicurus



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Michael Niedermayer Dec. 6, 2019, 9:50 a.m. UTC | #4
On Thu, Dec 05, 2019 at 09:54:44PM +0800, Limin Wang wrote:
> On Wed, Dec 04, 2019 at 08:31:15PM +0100, Michael Niedermayer wrote:
> > On Fri, Nov 22, 2019 at 09:50:36AM +0800, lance.lmwang@gmail.com wrote:
> > > From: Limin Wang <lance.lmwang@gmail.com>
> > > 
> > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > > ---
> > >  libavfilter/vf_elbg.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > will apply
> 
> Thanks, please help to review the PATCH v2 2/3 and 3/3 also, 
> they're fix the same typo.

will apply them too

thanks

[...]
diff mbox

Patch

diff --git a/libavfilter/vf_elbg.c b/libavfilter/vf_elbg.c
index b59da9ec85..5bccb5f58d 100644
--- a/libavfilter/vf_elbg.c
+++ b/libavfilter/vf_elbg.c
@@ -36,7 +36,7 @@ 
 typedef struct ELBGContext {
     const AVClass *class;
     AVLFG lfg;
-    unsigned int lfg_seed;
+    int64_t lfg_seed;
     int max_steps_nb;
     int *codeword;
     int codeword_length;
@@ -56,8 +56,8 @@  static const AVOption elbg_options[] = {
     { "l",               "set codebook length", OFFSET(codebook_length), AV_OPT_TYPE_INT, { .i64 = 256 }, 1, INT_MAX, FLAGS },
     { "nb_steps", "set max number of steps used to compute the mapping", OFFSET(max_steps_nb), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS },
     { "n",        "set max number of steps used to compute the mapping", OFFSET(max_steps_nb), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS },
-    { "seed", "set the random seed", OFFSET(lfg_seed), AV_OPT_TYPE_INT, {.i64 = -1}, -1, UINT32_MAX, FLAGS },
-    { "s",    "set the random seed", OFFSET(lfg_seed), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, UINT32_MAX, FLAGS },
+    { "seed", "set the random seed", OFFSET(lfg_seed), AV_OPT_TYPE_INT64, {.i64 = -1}, -1, UINT32_MAX, FLAGS },
+    { "s",    "set the random seed", OFFSET(lfg_seed), AV_OPT_TYPE_INT64, { .i64 = -1 }, -1, UINT32_MAX, FLAGS },
     { "pal8", "set the pal8 output", OFFSET(pal8), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS },
     { NULL }
 };